docs: batch one-line typo and syntax fixes#118
Open
Yetkin Timocin (ytimocin) wants to merge 2 commits into
Open
docs: batch one-line typo and syntax fixes#118Yetkin Timocin (ytimocin) wants to merge 2 commits into
Yetkin Timocin (ytimocin) wants to merge 2 commits into
Conversation
- affinities.md: use DoesNotExist (the correct LabelSelector operator) in place of NotExists in prose, matching the YAML example below. - crp.md: PickN affinity example, preference is a single struct, not a slice; remove leading dash and quote the label value. - kind.md: cleanup deletes configmap kf-cm (the name created earlier), not app. - on-prem.md: define MEMBER_CLUSTER_CONTEXT before first use in the Confirm-the-placement section, mirroring HUB_CLUSTER_CONTEXT. Closes #103 Closes #102 Closes #98 Closes #95 Signed-off-by: Yetkin Timocin <ytimocin@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bundled small doc fixes — each one is a one- or two-line change against a different file:
affinities.md: prose saidNotExists; the correctLabelSelectorRequirementoperator isDoesNotExist. The YAML example on the same page already usesDoesNotExist, so this just makes the prose match.crp.md: PickN affinity example hadpreference:as a list (- labelSelector:);preferenceis a singleClusterSelectorTerm, not a slice. Also quoted thecritical-level: \"1\"value to match the label-as-string contract.kind.md: cleanup saidkubectl delete configmap app -n kubefleet-samplebut the create step useskf-cm. Renamed the cleanup tokf-cm.on-prem.md: the script-based path used\$MEMBER_CLUSTER_CONTEXTwithout ever setting it. Added anexport MEMBER_CLUSTER_CONTEXT=YOUR-MEMBER-CLUSTER-CONTEXTinstruction before the first usage, mirroring howHUB_CLUSTER_CONTEXTis introduced near the top of the doc.Closes #103.
Closes #102.
Closes #98.
Closes #95.
Test plan