Skip to content

chore: maintenance of OWNERS files #2123

Merged
google-oss-prow[bot] merged 2 commits into
kubeflow:mainfrom
tarilabs:tarilabs-20260119-ownersmaintenance
Jan 20, 2026
Merged

chore: maintenance of OWNERS files #2123
google-oss-prow[bot] merged 2 commits into
kubeflow:mainfrom
tarilabs:tarilabs-20260119-ownersmaintenance

Conversation

@tarilabs
Copy link
Copy Markdown
Member

Description

Introduced kubeflow/internal-acls#882 to add @kubeflow/kubeflow-hub-team with Write access to KF/model-registry, specifically for:

Specifically, see kubeflow/internal-acls#882 (comment):

I think, you can remove myself @zijianjoy, and others from that team who are not involved in the Hub development at the moment

Hence,

moving:

as emeritus here too.

Keeping @andreyvelich being part of KSC for any special operations we may require.

Then, add a simple workflow to annotate OWNERS file in case some entry in the file is not (yet?) reflected in the kubeflow-hub-team in the KF ACL. Make the workflow only annotate the file and non-blocking for PR merges.

How Has This Been Tested?

GitHub action.

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • The commits have meaningful messages
  • Automated tests are provided as part of the PR for major new functionalities; testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.
  • For first time contributors: Please reach out to the Reviewers to ensure all tests are being run, ensuring the label ok-to-test has been added to the PR.

If you have UI changes

  • The developer has added tests or explained why testing cannot be added.
  • Included any necessary screenshots or gifs if it was a UI change.
  • Verify that UI/UX changes conform the UX guidelines for Kubeflow.

/hold for discussion in bi-weekly meeting.

see kubeflow/internal-acls#882 (comment)

moving:
  - ckadner
  - Tomcli
  - zijianjoy

as emeritus.
Keeping andreyvelich being part of KSC for any special operations
we may require

Signed-off-by: Matteo Mortari <matteo.mortari@gmail.com>
@tarilabs
Copy link
Copy Markdown
Member Author

tarilabs commented Jan 19, 2026

demo as currently it's pretending <SPACE> is missing:

Screenshot 2026-01-19 at 08 06 44

Add a simple workflow to annotate OWENERS file in case some entry
in the file is not (yet?) reflected in the kubeflow-hub-team
in the KF ACL.
Make the workflow only annotate the file and non-blocking for PR merges.

Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Matteo Mortari <matteo.mortari@gmail.com>
@tarilabs tarilabs force-pushed the tarilabs-20260119-ownersmaintenance branch from f028ee7 to 6a3b764 Compare January 19, 2026 07:08
Copy link
Copy Markdown
Member

@pboyd pboyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ederign
Copy link
Copy Markdown
Member

ederign commented Jan 19, 2026

/lgtm

@Al-Pragliola
Copy link
Copy Markdown
Contributor

/lgtm

@tarilabs
Copy link
Copy Markdown
Member Author

/unhold
we discussed this in the Kubeflow call yesterday, 2026-01-19

Copy link
Copy Markdown
Member

@ederign ederign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@google-oss-prow
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ederign

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow Bot merged commit 234dd84 into kubeflow:main Jan 20, 2026
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants