Skip to content

ci: Remove OWNERS file exclusion from readme-check.yml paths-ignore#163

Merged
google-oss-prow[bot] merged 1 commit into
kubeflow:mainfrom
hbelmiro:owners-should-trigger-readme-check
May 28, 2026
Merged

ci: Remove OWNERS file exclusion from readme-check.yml paths-ignore#163
google-oss-prow[bot] merged 1 commit into
kubeflow:mainfrom
hbelmiro:owners-should-trigger-readme-check

Conversation

@hbelmiro
Copy link
Copy Markdown
Contributor

Description of your changes:
The README generator reads OWNERS files to populate ownership info in generated READMEs. Commit 35faeb6 excluded OWNERS from all workflow triggers, but this means OWNERS changes can merge without verifying the README is still in sync.

This removes the !**/OWNERS exclusion from readme-check.yml only — the other workflows correctly ignore OWNERS since they don't use its content.

Checklist:

Pre-Submission Checklist

Additional Checklist Items for New or Updated Components/Pipelines

  • metadata.yaml includes fresh lastVerified timestamp
  • All required files
    are present and complete
  • OWNERS file lists appropriate maintainers
  • README provides clear documentation with usage examples
  • Component follows snake_case naming convention
  • No security vulnerabilities in dependencies
  • Containerfile included if using a custom base image

Signed-off-by: Helber Belmiro <helber.belmiro@gmail.com>
@hbelmiro hbelmiro marked this pull request as ready for review May 28, 2026 16:25
Copilot AI review requested due to automatic review settings May 28, 2026 16:25
@VaniHaripriya
Copy link
Copy Markdown
Contributor

/lgtm

@hbelmiro
Copy link
Copy Markdown
Contributor Author

/approve

@google-oss-prow
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hbelmiro

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hbelmiro
Copy link
Copy Markdown
Contributor Author

/ok-to-test

@google-oss-prow google-oss-prow Bot merged commit c57603c into kubeflow:main May 28, 2026
15 checks passed
@hbelmiro hbelmiro deleted the owners-should-trigger-readme-check branch May 28, 2026 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants