Fix workflow compiler tests by ignoring .files#13455
Open
ntny wants to merge 1 commit into
Open
Conversation
… are present in test data directories. macOS can create `.DS_Store` files when a directory is opened in Finder (see https://en.wikipedia.org/wiki/.DS_Store). The workflow compiler test helper collected all files from test_data so these hidden files could be treated as pipeline specs and break the tests. This change adds dotfiles to the existing file filter and extracts the filter into a shared helper to avoid duplicating. Signed-off-by: arpechenin <arpechenin@avito.ru>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Refactors file filtering logic in test utilities into a shared helper and switches a file open call to read-only.
Changes:
- Extracted file-filter logic into
isPipelineTestFilehelper, also excluding dotfiles. - Replaced two inline filter conditions with calls to the new helper.
- Changed
os.OpenFile(..., O_RDWR, 0o644)toos.Open(...)since the file is only read.
Comment on lines
+119
to
+125
| func isPipelineTestFile(fileName string) bool { | ||
| return !strings.HasPrefix(fileName, ".") && | ||
| !strings.Contains(fileName, ".py") && | ||
| fileName != "Dockerfile" && | ||
| !strings.Contains(fileName, ".md") && | ||
| !strings.Contains(fileName, ".ipynb") | ||
| } |
ntny
changed the title
ntny
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
macOS can create
.DS_Storefiles when a directory is opened in Finder (see https://en.wikipedia.org/wiki/.DS_Store). The workflow compiler test helper collected all files from test_data so these hidden files could be treated as pipeline specs and break the tests.This change adds dotfiles to the existing file filter and extracts the filter into a shared helper to avoid duplicating.
Description of your changes:
Checklist: