Skip to content

Conversation

@stephenfin
Copy link

@stephenfin stephenfin commented Jan 9, 2026

This PR bumps openapi-generator to the last version to support the "legacy" python generator that was the default until v5.0.0. A future PR will need to migrate thing to the new default generator, but that will likely come with significant changes for users.

It is expected that this PR be merged in tandem with kubernetes-client/python#2499

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: stephenfin
Once this PR has been reviewed and has the lgtm label, please assign brendandburns for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from yliaog January 9, 2026 12:38
@k8s-ci-robot
Copy link
Contributor

Welcome @stephenfin!

It looks like this is your first PR to kubernetes-client/gen 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/gen has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 9, 2026
This is the first release in v5.x series. We need to switch the
python-legacy generator to ensure our package layout remains the same.

Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
We skip past v6.1.0 and v6.2.0 since there were no changes in these
releases.

Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Once again, we skip over releases (v6.4.0 and v6.5.0) since they don't
introduce any changes.

This is the last version to support the python-legacy generator. We will
likely need to start providing custom templates to support v7.x

Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
@stephenfin stephenfin force-pushed the bump-python-openapi-generator branch from 27a0d67 to 365296e Compare January 9, 2026 14:18
@stephenfin stephenfin changed the title Bump python generator to openapi-generator v5.4.0 Bump python generator to openapi-generator v6.6.0 Jan 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants