tests/bats: add leader election e2e test for compute-domain-controller by anishbista60 · Pull Request #1094 · kubernetes-sigs/dra-driver-nvidia-gpu

anishbista60 · 2026-05-02T10:46:22Z

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR introduces the e2e test for the changes that was introduced at feat(controller): Add leader election for high availability #851

Which issue(s) this PR is related to:

#970

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation (design docs, usage docs, etc.):

Checklist

make check test passes locally
make check-generate passes if api/ changed (CRDs, deepcopy, informers, listers, clientset)
make check-modules passes if go.mod / go.sum changed
Tests added or updated for the change
Helm chart (deployments/helm) updated if flags, RBAC, or defaults changed

netlify · 2026-05-02T10:46:27Z

✅ Deploy Preview for dra-driver-nvidia-gpu ready!

Name	Link
🔨 Latest commit	`e0b8f25`
🔍 Latest deploy log	https://app.netlify.com/projects/dra-driver-nvidia-gpu/deploys/69fc181ca83ede0008ab6217
😎 Deploy Preview	https://deploy-preview-1094--dra-driver-nvidia-gpu.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

linux-foundation-easycla · 2026-05-02T10:46:29Z

The committers listed above are authorized under a signed CLA.

✅ login: anishbista60 / name: anishbista60 (5c289dc)

k8s-ci-robot · 2026-05-02T10:46:30Z

Welcome @anishbista60!

It looks like this is your first PR to kubernetes-sigs/dra-driver-nvidia-gpu 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/dra-driver-nvidia-gpu has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2026-05-02T10:46:31Z

Hi @anishbista60. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Signed-off-by: anishbista60 <anishbista053@gmail.com>

shivamerla · 2026-05-05T04:52:14Z

/ok-to-test

anishbista60 · 2026-05-05T11:28:14Z

connection timing out. Seems not related to my PR right ?

anishbista60 · 2026-05-06T03:23:51Z

/test pull-dra-driver-nvidia-gpu-e2e-lambda-gpu-gh200
/test pull-dra-driver-nvidia-gpu-e2e-gcp-nvkind

shivamerla · 2026-05-06T16:49:45Z

/lgtm
/approve

k8s-ci-robot · 2026-05-06T16:49:54Z

LGTM label has been added.

Details

Git tree hash: 7c44110331a243040a47bf8f23ded2524f8a918f

shivamerla · 2026-05-06T16:50:15Z

connection timing out. Seems not related to my PR right ?

Yes, not related to your PR.

shivamerla · 2026-05-06T17:25:14Z

/skip tests

anishbista60 · 2026-05-06T17:39:05Z

@shivamerla I know this project is particular to nvidia and most of people working here are from nvidia itself.
You guys have internal sprint/planning for this project which is not always visible in github.

I would like to participate into more issue related to patch, test, feature, docs e.t.c . How can i move forward?

I would be more than happy to work on that assigned issue on priority. Thank you

shivamerla · 2026-05-07T02:51:21Z

@shivamerla I know this project is particular to nvidia and most of people working here are from nvidia itself. You guys have internal sprint/planning for this project which is not always visible in github.

I would like to participate into more issue related to patch, test, feature, docs e.t.c . How can i move forward?

I would be more than happy to work on that assigned issue on priority. Thank you

@anishbista60 We do have a public project planning board that we use to track issues by milestone. Please comment on issues you want to take up and we can assign: DRA Driver for NVIDIA GPUs (view)

shivamerla · 2026-05-07T02:52:32Z

@anishbista60 mock NVML tests are failing, can you take a look.

Signed-off-by: anish bista <anishbista053@gmail.com>

anishbista60 · 2026-05-07T04:48:56Z

@shivamerla can we trigger CI again ?

shivamerla · 2026-05-07T05:46:46Z

/ok-to-test e0b8f25

shivamerla · 2026-05-07T06:03:03Z

/lgtm
/approve

k8s-ci-robot · 2026-05-07T06:03:33Z

LGTM label has been added.

Details

Git tree hash: ffbd907934b37e92e5a4556a162f61ea63404a47

k8s-ci-robot · 2026-05-07T06:03:37Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anishbista60, shivamerla

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [shivamerla]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

shivamerla · 2026-05-07T06:06:38Z

/release-note-none

github-project-automation Bot added this to DRA Driver for NVIDIA GPUs May 2, 2026

k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label May 2, 2026

github-project-automation Bot moved this to Backlog in DRA Driver for NVIDIA GPUs May 2, 2026

k8s-ci-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label May 2, 2026

k8s-ci-robot requested review from guptaNswati and visheshtanksale May 2, 2026 10:46

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 2, 2026

anishbista60 marked this pull request as draft May 2, 2026 10:46

anishbista60 force-pushed the test branch from 38882b8 to efc7668 Compare May 2, 2026 17:27

anishbista60 marked this pull request as ready for review May 2, 2026 17:37

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 2, 2026

k8s-ci-robot requested a review from klueska May 2, 2026 17:37

shivamerla reviewed May 4, 2026

View reviewed changes

Comment thread tests/bats/test_cd_leader_election.bats Outdated

shivamerla reviewed May 4, 2026

View reviewed changes

Comment thread tests/bats/test_cd_leader_election.bats Outdated

shivamerla reviewed May 4, 2026

View reviewed changes

Comment thread tests/bats/test_cd_leader_election.bats Outdated

tests/bats: add leader election e2e test for compute-domain-controller

5c289dc

Signed-off-by: anishbista60 <anishbista053@gmail.com>

anishbista60 force-pushed the test branch from efc7668 to 5c289dc Compare May 5, 2026 02:49

anishbista60 requested a review from shivamerla May 5, 2026 02:50

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 5, 2026

k8s-ci-robot assigned shivamerla May 6, 2026

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 6, 2026

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 6, 2026

fix: wait before checking the ready status

e0b8f25

Signed-off-by: anish bista <anishbista053@gmail.com>

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 7, 2026

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 7, 2026

k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 7, 2026

k8s-ci-robot merged commit 40eb2fd into kubernetes-sigs:main May 7, 2026
18 checks passed

github-project-automation Bot moved this from Backlog to Done in DRA Driver for NVIDIA GPUs May 7, 2026

anishbista60 deleted the test branch May 7, 2026 06:35

Conversation

anishbista60 commented May 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR is related to:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation (design docs, usage docs, etc.):

Checklist

Uh oh!

netlify Bot commented May 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for dra-driver-nvidia-gpu ready!

Uh oh!

linux-foundation-easycla Bot commented May 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

k8s-ci-robot commented May 2, 2026

Uh oh!

k8s-ci-robot commented May 2, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

shivamerla commented May 5, 2026

Uh oh!

anishbista60 commented May 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

anishbista60 commented May 6, 2026

Uh oh!

shivamerla commented May 6, 2026

Uh oh!

k8s-ci-robot commented May 6, 2026

Uh oh!

shivamerla commented May 6, 2026

Uh oh!

shivamerla commented May 6, 2026

Uh oh!

anishbista60 commented May 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shivamerla commented May 7, 2026

Uh oh!

shivamerla commented May 7, 2026

Uh oh!

anishbista60 commented May 7, 2026

Uh oh!

shivamerla commented May 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shivamerla commented May 7, 2026

Uh oh!

k8s-ci-robot commented May 7, 2026

Uh oh!

k8s-ci-robot commented May 7, 2026

Uh oh!

shivamerla commented May 7, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

anishbista60 commented May 2, 2026 •

edited

Loading

netlify Bot commented May 2, 2026 •

edited

Loading

linux-foundation-easycla Bot commented May 2, 2026 •

edited

Loading

anishbista60 commented May 5, 2026 •

edited

Loading

anishbista60 commented May 6, 2026 •

edited

Loading

shivamerla commented May 7, 2026 •

edited

Loading