Skip to content

Conversation

@davidesalerno
Copy link

What type of PR is this?
/kind test

Optionally add one or more of the following kinds if applicable:
/area conformance-test

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #4341

Does this PR introduce a user-facing change?:

Add conformance test to check that only Accepted Routes are considered as attachedRoute on Gateway status

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/test area/conformance-test Issues or PRs related to Conformance tests. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 17, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: davidesalerno
Once this PR has been reviewed and has the lgtm label, please assign arkodg for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 17, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @davidesalerno. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@davidesalerno davidesalerno changed the title fix: AttachedRoutes conformance tests to count only Accepted routes test: AttachedRoutes conformance tests to count only Accepted routes Dec 17, 2025
@mikemorris
Copy link
Contributor

mikemorris commented Dec 18, 2025

/ok-to-test

This was discussed in the December 8th Gateway API meeting and the proposed clarification of only counting Accepted routes was confirmed as the desired functionality.

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 18, 2025
@rikatz
Copy link
Member

rikatz commented Dec 18, 2025

/test pull-gateway-api-verify

seems like one of the flakes when trying to use prow to build arm images

@k8s-ci-robot
Copy link
Contributor

@davidesalerno: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-gateway-api-verify 87f4c78 link true /test pull-gateway-api-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

unresolved := metav1.Condition{
Type: string(v1.RouteConditionResolvedRefs),
notaccepted := metav1.Condition{
Type: string(v1.RouteReasonAccepted),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be RouteConditionAccepted and not RouteReasonAccepted

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, maybe you can check the two conditions: the Accepted, and the ResolvedRefs. We may still want to know if the ResolvedRefs conditions is also being added (in fact this condition helps identifying why it wasn't accepted).

Signed-off-by: Davide Salerno <dsalerno@redhat.com>
@davidesalerno davidesalerno force-pushed the fixAttachedRoutesConformanceTest branch from 87f4c78 to 08e872e Compare December 18, 2025 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/conformance-test Issues or PRs related to Conformance tests. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/test ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants