Conversation
…rom v1.13.1 to v1.14.0 for CVE remediation
|
Welcome @jeffrhea-wf! |
k8s-ci-robot
added
needs-ok-to-test
|
Hi @jeffrhea-wf. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jeffrhea-wf The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/XXL
DamianSawicki
left a comment
DamianSawicki
left a comment
There was a problem hiding this comment.
Speaking of CVEs, since you're already bumping github.com/coredns/coredns from v1.13.2 to v1.14.0, it might be worth bumping to https://github.com/coredns/coredns/releases/tag/v1.14.1, which fixes some CVEs from v1.14.0 according to the release description in the link.
IIRC (@Michcioperz to keep me honest), sometimes bumps of github.com/coredns/coredns introduce breaking changes, but this time I don't see anything suspicious in the release descriptions.
Other than that the PR looks fine. Thanks for taking this up!
/ok-to-test
k8s-ci-robot
added
ok-to-test
|
I don't see anything particularly scary in the changelogs, just to point out there's even a 1.14.2 now |
|
Good call on the coredns changes. Updated to latest 1.14.2. |
|
Thanks @jeffrhea-wf! Please take care of the CLA (#756 (comment)) and we should be ready to merge the PR :) |
k8s-ci-robot
added
cncf-cla: yes
|
/retest |
… 127.0.0.1 isntead of localhost. And updated the timeouts from 1s since it looked like the test was trying to ping the dns before it was actually ready
pkg/e2e/dns/dns.go
Outdated
| // SkyDNS listens as soon as Run() starts the skydns goroutine. | ||
| om.Eventually(func() error { | ||
| conn, err := net.Dial("tcp", "localhost:10053") | ||
| conn, err := net.Dial("tcp", "127.0.0.1:10053") |
There was a problem hiding this comment.
Updating timeouts is probably fine, but the need to replace localhost by 127.0.0.1 looks like a behavior change. Why is this need?
…s to localhost that were part of testing local ci build on a mac instead of linux machine
…o 127.0.0.1 changes that snuck in when I was testing local ci on a mac.
4 participants
Updating base image and go libraries to resolve the following CVEs:
CVE-2026-22796
CVE-2026-22796
CVE-2025-15467
CVE-2025-68151
CVE-2025-64702
Notes:
Coredns version 1.14.2 brings in some other updated lib that causes the pull-kubernetes-dns-test test to fail. Confirmed that only downgrading coredns doesn't resolve this failure, so I know this is a transitive dependency updated. I have not done any more testing to confirm which transitive dependency is the issue at this time.