Remove ginkgo/gomega dependency from root module#579
Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom Mar 17, 2026
Merged
Remove ginkgo/gomega dependency from root module#579k8s-ci-robot merged 1 commit intokubernetes:masterfrom
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
Conversation
Migrate proto and proto/validation tests from ginkgo/gomega to stdlib testing with t.Run subtests. This removes ginkgo/gomega and their transitive dependencies (slim-sprig, google/pprof) from go.mod, which in turn allows downstream consumers like k8s.io/apimachinery to have a cleaner dependency tree. Only 4 test files in the root module used ginkgo (the other 95% of tests already use stdlib testing). The test/integration submodule retains its own ginkgo dependency independently. All 51 tests pass across the 3 affected packages. Ref: kubernetes/kubernetes#127888
k8s-ci-robot
added
area/dependency
Contributor
|
Welcome @bryantbiggs! |
k8s-ci-robot
added
the
size/XXL
Member
|
great /assign @Jefftree |
Jefftree
reviewed
Mar 17, 2026
Member
Jefftree
left a comment
Jefftree
left a comment
There was a problem hiding this comment.
/lgtm
/approve
Do you also want to create the k/k bump PR?
| schema = models.LookupModel(model) | ||
| Expect(schema).ToNot(BeNil()) | ||
| // loadV18Models loads the v1.8 swagger schema and returns proto.Models. | ||
| func loadV18Models(t *testing.T) proto.Models { |
Member
There was a problem hiding this comment.
Didn't realize that we're still using Kubernetes v1.8 models. Not blocking for this PR but can we create an issue to update these?
Contributor
Author
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bryantbiggs, Jefftree The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This was referenced Mar 17, 2026
bryantbiggs
added a commit
to bryantbiggs/kubernetes
that referenced
this pull request
Mar 17, 2026
Bump k8s.io/kube-openapi to pick up kubernetes/kube-openapi#579 which removed ginkgo/gomega from the root module's test dependencies. This drops ginkgo/gomega as indirect dependencies from apimachinery, client-go, and other staging modules. Also removes transitive indirect deps that were only needed by ginkgo/gomega (Masterminds/semver, google/pprof, golang.org/x/tools) from several staging modules.
bryantbiggs
added a commit
to bryantbiggs/kubernetes
that referenced
this pull request
Mar 18, 2026
Bump k8s.io/kube-openapi to pick up kubernetes/kube-openapi#579 which moved the last ginkgo/gomega tests to stdlib testing and ran go mod tidy, removing ginkgo/gomega from kube-openapi's go.mod. This drops ginkgo/gomega as indirect deps from apimachinery. It also prunes Masterminds/semver, google/pprof, and golang.org/x/tools from client-go and other staging modules where they were only needed through kube-openapi's ginkgo/gomega chain. Contributes to kubernetes#127888
k8s-publishing-bot
pushed a commit
to kubernetes/apimachinery
that referenced
this pull request
Mar 18, 2026
Bump k8s.io/kube-openapi to pick up kubernetes/kube-openapi#579 which moved the last ginkgo/gomega tests to stdlib testing and ran go mod tidy, removing ginkgo/gomega from kube-openapi's go.mod. This drops ginkgo/gomega as indirect deps from apimachinery. It also prunes Masterminds/semver, google/pprof, and golang.org/x/tools from client-go and other staging modules where they were only needed through kube-openapi's ginkgo/gomega chain. Contributes to kubernetes/kubernetes#127888 Kubernetes-commit: 56cd74d879f1ba11aadcff95326f17a1cc2c82ef
k8s-publishing-bot
pushed a commit
to kubernetes/api
that referenced
this pull request
Mar 18, 2026
Bump k8s.io/kube-openapi to pick up kubernetes/kube-openapi#579 which moved the last ginkgo/gomega tests to stdlib testing and ran go mod tidy, removing ginkgo/gomega from kube-openapi's go.mod. This drops ginkgo/gomega as indirect deps from apimachinery. It also prunes Masterminds/semver, google/pprof, and golang.org/x/tools from client-go and other staging modules where they were only needed through kube-openapi's ginkgo/gomega chain. Contributes to kubernetes/kubernetes#127888 Kubernetes-commit: 56cd74d879f1ba11aadcff95326f17a1cc2c82ef
k8s-publishing-bot
pushed a commit
to kubernetes/client-go
that referenced
this pull request
Mar 18, 2026
Bump k8s.io/kube-openapi to pick up kubernetes/kube-openapi#579 which moved the last ginkgo/gomega tests to stdlib testing and ran go mod tidy, removing ginkgo/gomega from kube-openapi's go.mod. This drops ginkgo/gomega as indirect deps from apimachinery. It also prunes Masterminds/semver, google/pprof, and golang.org/x/tools from client-go and other staging modules where they were only needed through kube-openapi's ginkgo/gomega chain. Contributes to kubernetes/kubernetes#127888 Kubernetes-commit: 56cd74d879f1ba11aadcff95326f17a1cc2c82ef
k8s-publishing-bot
pushed a commit
to kubernetes/code-generator
that referenced
this pull request
Mar 18, 2026
Bump k8s.io/kube-openapi to pick up kubernetes/kube-openapi#579 which moved the last ginkgo/gomega tests to stdlib testing and ran go mod tidy, removing ginkgo/gomega from kube-openapi's go.mod. This drops ginkgo/gomega as indirect deps from apimachinery. It also prunes Masterminds/semver, google/pprof, and golang.org/x/tools from client-go and other staging modules where they were only needed through kube-openapi's ginkgo/gomega chain. Contributes to kubernetes/kubernetes#127888 Kubernetes-commit: 56cd74d879f1ba11aadcff95326f17a1cc2c82ef
k8s-publishing-bot
pushed a commit
to kubernetes/component-base
that referenced
this pull request
Mar 18, 2026
Bump k8s.io/kube-openapi to pick up kubernetes/kube-openapi#579 which moved the last ginkgo/gomega tests to stdlib testing and ran go mod tidy, removing ginkgo/gomega from kube-openapi's go.mod. This drops ginkgo/gomega as indirect deps from apimachinery. It also prunes Masterminds/semver, google/pprof, and golang.org/x/tools from client-go and other staging modules where they were only needed through kube-openapi's ginkgo/gomega chain. Contributes to kubernetes/kubernetes#127888 Kubernetes-commit: 56cd74d879f1ba11aadcff95326f17a1cc2c82ef
k8s-publishing-bot
pushed a commit
to kubernetes/component-helpers
that referenced
this pull request
Mar 18, 2026
Bump k8s.io/kube-openapi to pick up kubernetes/kube-openapi#579 which moved the last ginkgo/gomega tests to stdlib testing and ran go mod tidy, removing ginkgo/gomega from kube-openapi's go.mod. This drops ginkgo/gomega as indirect deps from apimachinery. It also prunes Masterminds/semver, google/pprof, and golang.org/x/tools from client-go and other staging modules where they were only needed through kube-openapi's ginkgo/gomega chain. Contributes to kubernetes/kubernetes#127888 Kubernetes-commit: 56cd74d879f1ba11aadcff95326f17a1cc2c82ef
k8s-publishing-bot
pushed a commit
to kubernetes/apiserver
that referenced
this pull request
Mar 18, 2026
Bump k8s.io/kube-openapi to pick up kubernetes/kube-openapi#579 which moved the last ginkgo/gomega tests to stdlib testing and ran go mod tidy, removing ginkgo/gomega from kube-openapi's go.mod. This drops ginkgo/gomega as indirect deps from apimachinery. It also prunes Masterminds/semver, google/pprof, and golang.org/x/tools from client-go and other staging modules where they were only needed through kube-openapi's ginkgo/gomega chain. Contributes to kubernetes/kubernetes#127888 Kubernetes-commit: 56cd74d879f1ba11aadcff95326f17a1cc2c82ef
k8s-publishing-bot
pushed a commit
to kubernetes/kube-aggregator
that referenced
this pull request
Mar 18, 2026
Bump k8s.io/kube-openapi to pick up kubernetes/kube-openapi#579 which moved the last ginkgo/gomega tests to stdlib testing and ran go mod tidy, removing ginkgo/gomega from kube-openapi's go.mod. This drops ginkgo/gomega as indirect deps from apimachinery. It also prunes Masterminds/semver, google/pprof, and golang.org/x/tools from client-go and other staging modules where they were only needed through kube-openapi's ginkgo/gomega chain. Contributes to kubernetes/kubernetes#127888 Kubernetes-commit: 56cd74d879f1ba11aadcff95326f17a1cc2c82ef
k8s-publishing-bot
pushed a commit
to kubernetes/sample-apiserver
that referenced
this pull request
Mar 18, 2026
Bump k8s.io/kube-openapi to pick up kubernetes/kube-openapi#579 which moved the last ginkgo/gomega tests to stdlib testing and ran go mod tidy, removing ginkgo/gomega from kube-openapi's go.mod. This drops ginkgo/gomega as indirect deps from apimachinery. It also prunes Masterminds/semver, google/pprof, and golang.org/x/tools from client-go and other staging modules where they were only needed through kube-openapi's ginkgo/gomega chain. Contributes to kubernetes/kubernetes#127888 Kubernetes-commit: 56cd74d879f1ba11aadcff95326f17a1cc2c82ef
k8s-publishing-bot
pushed a commit
to kubernetes/sample-controller
that referenced
this pull request
Mar 18, 2026
Bump k8s.io/kube-openapi to pick up kubernetes/kube-openapi#579 which moved the last ginkgo/gomega tests to stdlib testing and ran go mod tidy, removing ginkgo/gomega from kube-openapi's go.mod. This drops ginkgo/gomega as indirect deps from apimachinery. It also prunes Masterminds/semver, google/pprof, and golang.org/x/tools from client-go and other staging modules where they were only needed through kube-openapi's ginkgo/gomega chain. Contributes to kubernetes/kubernetes#127888 Kubernetes-commit: 56cd74d879f1ba11aadcff95326f17a1cc2c82ef
k8s-publishing-bot
pushed a commit
to kubernetes/apiextensions-apiserver
that referenced
this pull request
Mar 18, 2026
Bump k8s.io/kube-openapi to pick up kubernetes/kube-openapi#579 which moved the last ginkgo/gomega tests to stdlib testing and ran go mod tidy, removing ginkgo/gomega from kube-openapi's go.mod. This drops ginkgo/gomega as indirect deps from apimachinery. It also prunes Masterminds/semver, google/pprof, and golang.org/x/tools from client-go and other staging modules where they were only needed through kube-openapi's ginkgo/gomega chain. Contributes to kubernetes/kubernetes#127888 Kubernetes-commit: 56cd74d879f1ba11aadcff95326f17a1cc2c82ef
k8s-publishing-bot
pushed a commit
to kubernetes/metrics
that referenced
this pull request
Mar 18, 2026
Bump k8s.io/kube-openapi to pick up kubernetes/kube-openapi#579 which moved the last ginkgo/gomega tests to stdlib testing and ran go mod tidy, removing ginkgo/gomega from kube-openapi's go.mod. This drops ginkgo/gomega as indirect deps from apimachinery. It also prunes Masterminds/semver, google/pprof, and golang.org/x/tools from client-go and other staging modules where they were only needed through kube-openapi's ginkgo/gomega chain. Contributes to kubernetes/kubernetes#127888 Kubernetes-commit: 56cd74d879f1ba11aadcff95326f17a1cc2c82ef
k8s-publishing-bot
pushed a commit
to kubernetes/cli-runtime
that referenced
this pull request
Mar 18, 2026
Bump k8s.io/kube-openapi to pick up kubernetes/kube-openapi#579 which moved the last ginkgo/gomega tests to stdlib testing and ran go mod tidy, removing ginkgo/gomega from kube-openapi's go.mod. This drops ginkgo/gomega as indirect deps from apimachinery. It also prunes Masterminds/semver, google/pprof, and golang.org/x/tools from client-go and other staging modules where they were only needed through kube-openapi's ginkgo/gomega chain. Contributes to kubernetes/kubernetes#127888 Kubernetes-commit: 56cd74d879f1ba11aadcff95326f17a1cc2c82ef
k8s-publishing-bot
pushed a commit
to kubernetes/sample-cli-plugin
that referenced
this pull request
Mar 18, 2026
Bump k8s.io/kube-openapi to pick up kubernetes/kube-openapi#579 which moved the last ginkgo/gomega tests to stdlib testing and ran go mod tidy, removing ginkgo/gomega from kube-openapi's go.mod. This drops ginkgo/gomega as indirect deps from apimachinery. It also prunes Masterminds/semver, google/pprof, and golang.org/x/tools from client-go and other staging modules where they were only needed through kube-openapi's ginkgo/gomega chain. Contributes to kubernetes/kubernetes#127888 Kubernetes-commit: 56cd74d879f1ba11aadcff95326f17a1cc2c82ef
k8s-publishing-bot
pushed a commit
to kubernetes/kube-proxy
that referenced
this pull request
Mar 18, 2026
Bump k8s.io/kube-openapi to pick up kubernetes/kube-openapi#579 which moved the last ginkgo/gomega tests to stdlib testing and ran go mod tidy, removing ginkgo/gomega from kube-openapi's go.mod. This drops ginkgo/gomega as indirect deps from apimachinery. It also prunes Masterminds/semver, google/pprof, and golang.org/x/tools from client-go and other staging modules where they were only needed through kube-openapi's ginkgo/gomega chain. Contributes to kubernetes/kubernetes#127888 Kubernetes-commit: 56cd74d879f1ba11aadcff95326f17a1cc2c82ef
k8s-publishing-bot
pushed a commit
to kubernetes/cri-client
that referenced
this pull request
Mar 18, 2026
Bump k8s.io/kube-openapi to pick up kubernetes/kube-openapi#579 which moved the last ginkgo/gomega tests to stdlib testing and ran go mod tidy, removing ginkgo/gomega from kube-openapi's go.mod. This drops ginkgo/gomega as indirect deps from apimachinery. It also prunes Masterminds/semver, google/pprof, and golang.org/x/tools from client-go and other staging modules where they were only needed through kube-openapi's ginkgo/gomega chain. Contributes to kubernetes/kubernetes#127888 Kubernetes-commit: 56cd74d879f1ba11aadcff95326f17a1cc2c82ef
k8s-publishing-bot
pushed a commit
to kubernetes/kubelet
that referenced
this pull request
Mar 18, 2026
Bump k8s.io/kube-openapi to pick up kubernetes/kube-openapi#579 which moved the last ginkgo/gomega tests to stdlib testing and ran go mod tidy, removing ginkgo/gomega from kube-openapi's go.mod. This drops ginkgo/gomega as indirect deps from apimachinery. It also prunes Masterminds/semver, google/pprof, and golang.org/x/tools from client-go and other staging modules where they were only needed through kube-openapi's ginkgo/gomega chain. Contributes to kubernetes/kubernetes#127888 Kubernetes-commit: 56cd74d879f1ba11aadcff95326f17a1cc2c82ef
k8s-publishing-bot
pushed a commit
to kubernetes/controller-manager
that referenced
this pull request
Mar 18, 2026
Bump k8s.io/kube-openapi to pick up kubernetes/kube-openapi#579 which moved the last ginkgo/gomega tests to stdlib testing and ran go mod tidy, removing ginkgo/gomega from kube-openapi's go.mod. This drops ginkgo/gomega as indirect deps from apimachinery. It also prunes Masterminds/semver, google/pprof, and golang.org/x/tools from client-go and other staging modules where they were only needed through kube-openapi's ginkgo/gomega chain. Contributes to kubernetes/kubernetes#127888 Kubernetes-commit: 56cd74d879f1ba11aadcff95326f17a1cc2c82ef
k8s-publishing-bot
pushed a commit
to kubernetes/cloud-provider
that referenced
this pull request
Mar 18, 2026
Bump k8s.io/kube-openapi to pick up kubernetes/kube-openapi#579 which moved the last ginkgo/gomega tests to stdlib testing and ran go mod tidy, removing ginkgo/gomega from kube-openapi's go.mod. This drops ginkgo/gomega as indirect deps from apimachinery. It also prunes Masterminds/semver, google/pprof, and golang.org/x/tools from client-go and other staging modules where they were only needed through kube-openapi's ginkgo/gomega chain. Contributes to kubernetes/kubernetes#127888 Kubernetes-commit: 56cd74d879f1ba11aadcff95326f17a1cc2c82ef
k8s-publishing-bot
pushed a commit
to kubernetes/kube-controller-manager
that referenced
this pull request
Mar 18, 2026
Bump k8s.io/kube-openapi to pick up kubernetes/kube-openapi#579 which moved the last ginkgo/gomega tests to stdlib testing and ran go mod tidy, removing ginkgo/gomega from kube-openapi's go.mod. This drops ginkgo/gomega as indirect deps from apimachinery. It also prunes Masterminds/semver, google/pprof, and golang.org/x/tools from client-go and other staging modules where they were only needed through kube-openapi's ginkgo/gomega chain. Contributes to kubernetes/kubernetes#127888 Kubernetes-commit: 56cd74d879f1ba11aadcff95326f17a1cc2c82ef
k8s-publishing-bot
pushed a commit
to kubernetes/cluster-bootstrap
that referenced
this pull request
Mar 18, 2026
Bump k8s.io/kube-openapi to pick up kubernetes/kube-openapi#579 which moved the last ginkgo/gomega tests to stdlib testing and ran go mod tidy, removing ginkgo/gomega from kube-openapi's go.mod. This drops ginkgo/gomega as indirect deps from apimachinery. It also prunes Masterminds/semver, google/pprof, and golang.org/x/tools from client-go and other staging modules where they were only needed through kube-openapi's ginkgo/gomega chain. Contributes to kubernetes/kubernetes#127888 Kubernetes-commit: 56cd74d879f1ba11aadcff95326f17a1cc2c82ef
k8s-publishing-bot
pushed a commit
to kubernetes/csi-translation-lib
that referenced
this pull request
Mar 18, 2026
Bump k8s.io/kube-openapi to pick up kubernetes/kube-openapi#579 which moved the last ginkgo/gomega tests to stdlib testing and ran go mod tidy, removing ginkgo/gomega from kube-openapi's go.mod. This drops ginkgo/gomega as indirect deps from apimachinery. It also prunes Masterminds/semver, google/pprof, and golang.org/x/tools from client-go and other staging modules where they were only needed through kube-openapi's ginkgo/gomega chain. Contributes to kubernetes/kubernetes#127888 Kubernetes-commit: 56cd74d879f1ba11aadcff95326f17a1cc2c82ef
k8s-publishing-bot
pushed a commit
to kubernetes/kubectl
that referenced
this pull request
Mar 18, 2026
Bump k8s.io/kube-openapi to pick up kubernetes/kube-openapi#579 which moved the last ginkgo/gomega tests to stdlib testing and ran go mod tidy, removing ginkgo/gomega from kube-openapi's go.mod. This drops ginkgo/gomega as indirect deps from apimachinery. It also prunes Masterminds/semver, google/pprof, and golang.org/x/tools from client-go and other staging modules where they were only needed through kube-openapi's ginkgo/gomega chain. Contributes to kubernetes/kubernetes#127888 Kubernetes-commit: 56cd74d879f1ba11aadcff95326f17a1cc2c82ef
k8s-publishing-bot
pushed a commit
to kubernetes/pod-security-admission
that referenced
this pull request
Mar 18, 2026
Bump k8s.io/kube-openapi to pick up kubernetes/kube-openapi#579 which moved the last ginkgo/gomega tests to stdlib testing and ran go mod tidy, removing ginkgo/gomega from kube-openapi's go.mod. This drops ginkgo/gomega as indirect deps from apimachinery. It also prunes Masterminds/semver, google/pprof, and golang.org/x/tools from client-go and other staging modules where they were only needed through kube-openapi's ginkgo/gomega chain. Contributes to kubernetes/kubernetes#127888 Kubernetes-commit: 56cd74d879f1ba11aadcff95326f17a1cc2c82ef
k8s-publishing-bot
pushed a commit
to kubernetes/dynamic-resource-allocation
that referenced
this pull request
Mar 18, 2026
Bump k8s.io/kube-openapi to pick up kubernetes/kube-openapi#579 which moved the last ginkgo/gomega tests to stdlib testing and ran go mod tidy, removing ginkgo/gomega from kube-openapi's go.mod. This drops ginkgo/gomega as indirect deps from apimachinery. It also prunes Masterminds/semver, google/pprof, and golang.org/x/tools from client-go and other staging modules where they were only needed through kube-openapi's ginkgo/gomega chain. Contributes to kubernetes/kubernetes#127888 Kubernetes-commit: 56cd74d879f1ba11aadcff95326f17a1cc2c82ef
k8s-publishing-bot
pushed a commit
to kubernetes/kube-scheduler
that referenced
this pull request
Mar 18, 2026
Bump k8s.io/kube-openapi to pick up kubernetes/kube-openapi#579 which moved the last ginkgo/gomega tests to stdlib testing and ran go mod tidy, removing ginkgo/gomega from kube-openapi's go.mod. This drops ginkgo/gomega as indirect deps from apimachinery. It also prunes Masterminds/semver, google/pprof, and golang.org/x/tools from client-go and other staging modules where they were only needed through kube-openapi's ginkgo/gomega chain. Contributes to kubernetes/kubernetes#127888 Kubernetes-commit: 56cd74d879f1ba11aadcff95326f17a1cc2c82ef
k8s-publishing-bot
pushed a commit
to kubernetes/endpointslice
that referenced
this pull request
Mar 18, 2026
Bump k8s.io/kube-openapi to pick up kubernetes/kube-openapi#579 which moved the last ginkgo/gomega tests to stdlib testing and ran go mod tidy, removing ginkgo/gomega from kube-openapi's go.mod. This drops ginkgo/gomega as indirect deps from apimachinery. It also prunes Masterminds/semver, google/pprof, and golang.org/x/tools from client-go and other staging modules where they were only needed through kube-openapi's ginkgo/gomega chain. Contributes to kubernetes/kubernetes#127888 Kubernetes-commit: 56cd74d879f1ba11aadcff95326f17a1cc2c82ef
nmn3m
pushed a commit
to nmn3m/kubernetes
that referenced
this pull request
Mar 22, 2026
Bump k8s.io/kube-openapi to pick up kubernetes/kube-openapi#579 which moved the last ginkgo/gomega tests to stdlib testing and ran go mod tidy, removing ginkgo/gomega from kube-openapi's go.mod. This drops ginkgo/gomega as indirect deps from apimachinery. It also prunes Masterminds/semver, google/pprof, and golang.org/x/tools from client-go and other staging modules where they were only needed through kube-openapi's ginkgo/gomega chain. Contributes to kubernetes#127888
ameukam
pushed a commit
to ameukam/kubernetes
that referenced
this pull request
Apr 8, 2026
Bump k8s.io/kube-openapi to pick up kubernetes/kube-openapi#579 which moved the last ginkgo/gomega tests to stdlib testing and ran go mod tidy, removing ginkgo/gomega from kube-openapi's go.mod. This drops ginkgo/gomega as indirect deps from apimachinery. It also prunes Masterminds/semver, google/pprof, and golang.org/x/tools from client-go and other staging modules where they were only needed through kube-openapi's ginkgo/gomega chain. Contributes to kubernetes#127888 Signed-off-by: Arnaud Meukam <ameukam@gmail.com>
k8s-publishing-bot
pushed a commit
to kubernetes/sample-controller
that referenced
this pull request
Apr 9, 2026
Bump k8s.io/kube-openapi to pick up kubernetes/kube-openapi#579 which moved the last ginkgo/gomega tests to stdlib testing and ran go mod tidy, removing ginkgo/gomega from kube-openapi's go.mod. This drops ginkgo/gomega as indirect deps from apimachinery. It also prunes Masterminds/semver, google/pprof, and golang.org/x/tools from client-go and other staging modules where they were only needed through kube-openapi's ginkgo/gomega chain. Contributes to kubernetes/kubernetes#127888 Kubernetes-commit: 56cd74d879f1ba11aadcff95326f17a1cc2c82ef
k8s-publishing-bot
pushed a commit
to kubernetes/metrics
that referenced
this pull request
Apr 9, 2026
Bump k8s.io/kube-openapi to pick up kubernetes/kube-openapi#579 which moved the last ginkgo/gomega tests to stdlib testing and ran go mod tidy, removing ginkgo/gomega from kube-openapi's go.mod. This drops ginkgo/gomega as indirect deps from apimachinery. It also prunes Masterminds/semver, google/pprof, and golang.org/x/tools from client-go and other staging modules where they were only needed through kube-openapi's ginkgo/gomega chain. Contributes to kubernetes/kubernetes#127888 Kubernetes-commit: 56cd74d879f1ba11aadcff95326f17a1cc2c82ef
k8s-publishing-bot
pushed a commit
to kubernetes/cluster-bootstrap
that referenced
this pull request
Apr 9, 2026
Bump k8s.io/kube-openapi to pick up kubernetes/kube-openapi#579 which moved the last ginkgo/gomega tests to stdlib testing and ran go mod tidy, removing ginkgo/gomega from kube-openapi's go.mod. This drops ginkgo/gomega as indirect deps from apimachinery. It also prunes Masterminds/semver, google/pprof, and golang.org/x/tools from client-go and other staging modules where they were only needed through kube-openapi's ginkgo/gomega chain. Contributes to kubernetes/kubernetes#127888 Kubernetes-commit: 56cd74d879f1ba11aadcff95326f17a1cc2c82ef
k8s-publishing-bot
pushed a commit
to kubernetes/csi-translation-lib
that referenced
this pull request
Apr 9, 2026
Bump k8s.io/kube-openapi to pick up kubernetes/kube-openapi#579 which moved the last ginkgo/gomega tests to stdlib testing and ran go mod tidy, removing ginkgo/gomega from kube-openapi's go.mod. This drops ginkgo/gomega as indirect deps from apimachinery. It also prunes Masterminds/semver, google/pprof, and golang.org/x/tools from client-go and other staging modules where they were only needed through kube-openapi's ginkgo/gomega chain. Contributes to kubernetes/kubernetes#127888 Kubernetes-commit: 56cd74d879f1ba11aadcff95326f17a1cc2c82ef
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pkg/util/protoandpkg/util/proto/validationtests from ginkgo/gomega to stdlibtestingwitht.Runsubtests_suite_test.go) filesgo mod tidyto removegithub.com/onsi/ginkgo/v2,github.com/onsi/gomega, and their transitive deps (slim-sprig,google/pprof) fromgo.modOnly 4 test files in the root module used ginkgo — the other 95% of tests already use stdlib
testing. Thetest/integrationsubmodule retains its own independent ginkgo dependency.Motivation
k8s.io/apimachinerydepends onk8s.io/kube-openapi, which transitively pulls ginkgo/gomega into apimachinery'sgo.modas indirect deps. Removing them from kube-openapi's root module cleans up the dependency tree for all downstream consumers, contributing to the goal of making client-go lighter (kubernetes/kubernetes#127888).This follows the pattern of recent Kubernetes dependency cleanup work:
Test plan
go test ./pkg/util/proto/... -count=1— all 51 tests pass across 3 packages/area dependency