feat: add --image-repository support for Helm-based addons

[PhantomInTheWire]

This PR adds support custom image repository for addons based on helm.

• Implement helm repo add before chart installation
• Passes cluster's ImageRepository config to Helm
• Includes unit tests for different mirror scenarios

relevant issue: #21257

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: PhantomInTheWire
Once this PR has been reviewed and has the lgtm label, please assign prezha for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Welcome @PhantomInTheWire!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @PhantomInTheWire. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[minikube-bot]

Can one of the admins verify this patch?

[medyagh]

@PhantomInTheWire the issue you linked talks about doing one exmaple of helm based addon, we have not added one yet

[PhantomInTheWire]

@medyagh i initially wanted to migrate an existing addon that but but figured adding this first would be needed for a full migration. i was under the impression that we want to migrate existing addons, is that not the case? i thought not being able to use --image-repository flag was the blocker, if not that what exactly would we need to cloase #21257

[PhantomInTheWire]

@medyagh thanks for the feedback earlier!

Just wanted to follow up and clarify intent: this PR only adds the plumbing needed for --image-repository to work with Helm-based addons, so that existing addons can be migrated incrementally afterward.

If the expectation is that this PR should also migrate at least one addon as an example, I’m happy to do that, just wanted to confirm the preferred direction before proceeding.

Appreciate your guidance.