Build nft with JSON (and xtables-compat) support - #4464
Merged
kubernetes-prow[bot] merged 1 commit intoJul 13, 2026
Conversation
kubernetes-prow
Bot
added
kind/bug
kubernetes-prow
Bot
added
the
size/M
Contributor
Author
|
/release-note-none |
kubernetes-prow
Bot
added
release-note-none
We were installing the JSON build dep but not telling configure to use it. Also, in the interest of minimzing differences from upstream, add xtables support (which adds additional output when printing some `iptables-nft`-generated rules).
danwinship
force-pushed
the
nftables-with-json
branch
from
July 10, 2026 19:42
a1ef589 to
a64ee83
Compare
Member
|
/lgtm /assign @saschagrunert It is great we don;t have to carry patch |
kubernetes-prow
Bot
added
the
lgtm
saschagrunert
approved these changes
Jul 13, 2026
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aojea, danwinship, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubernetes-prow
Bot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were installing the JSON build dep but not telling configure to use it.
Also, in the interest of minimzing differences from upstream, add xtables support (which adds additional output when printing some
iptables-nft-generated rules).This makes us no longer need the
#include <stdlib.h>patch, so I removed it, though I left the patching framework in place even though there are no longer any patches... I wasn't sure about that.../kind bug
/assign @aojea