Strip remote creds instead of excluding .git - #4500
Merged
Merged
Conversation
kubernetes-prow
Bot
added
release-note
Member
Author
|
Confirmed that the remotes don't have the credentials: 
|
saschagrunert
left a comment
saschagrunert
left a comment
Member
There was a problem hiding this comment.
LGTM overall - sound fix for the regression. Three minor observations inline.
Signed-off-by: Adolfo García Veytia (Puerco) <puerco@carabiner.dev>
Member
Author
|
OK, it seems the only real action item was adding a comment. I've added it so this should be ready to go. PTAL |
saschagrunert
approved these changes
Aug 26, 2026
saschagrunert
left a comment
saschagrunert
left a comment
Member
There was a problem hiding this comment.
LGTM, thanks for the quick fix!
kubernetes-prow
Bot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: puerco, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
In #4424 we removed the .git directory from the source tarball that stage hands to release. Unfortunately this breaks the release process as
krel releasedies when attempting to open the repository.This PR replaces que .git exclusion with logic to keep the git directory but now we strip all the remote credentials before tarring the kubernetes source.
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
/cc @saschagrunert
I've run a full stage+release on a branch containing this patch here:
https://console.cloud.google.com/cloud-build/builds;region=us-central1/b3257414-5321-4652-98e3-e0a0eb5be6e1?project=k8s-release
Does this PR introduce a user-facing change?