-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Update SIG Node CI test coverage guide #35912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: natasha41575 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
| <td>os | ||
| </td> | ||
| <td>cos, ubuntu, fedora | ||
| <td>COS, ubuntu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
curious why fedora was dropped? they're the only cri-o tests AFAIU
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah I can put them back for cri-o, thanks for the callout!
| <td>cri | ||
| </td> | ||
| <td>containerd, CRI-O | ||
| <td>containerd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know we sometimes struggle to keep them green but I'd love cri-o tests to be kept here if possible
|
/triage accepted |
Here is a proposal for how we can reorganize the SIG Node CI testgrid to make tests easier to find. I generally find it hard to navigate the current testgrid; it is not obvious (at least to me) where or if a particular test is running in the testgrid today.
This came out of me picking up kubernetes/kubernetes#134862; while starting to look at what we had previously defined as our test coverage guidance (which is still not implemented), I thought the current proposal can be improved. This is intended to be an incremental improvement, and can be iterated upon in the future. I also want to be careful not to remove any existing test coverage.
Also another, note, there are some highly specialized test tabs like
sig-node-problem-detector,sig-node-security-profiles-operator,sig-node-ec2,sig-node-gpuetc, I don't intend to touch those.All feedback and suggestions are welcome. I am not an expert on test-infra or all node features so please feel free to bring up issues or mistakes :)
/sig node
/assign @SergeyKanzhelev
/cc @mariafromano-25 @haircommander @kannon92
/hold
just to gate merging until we are ready