Skip to content

fix(cloudflared): remove chart default pdb maxunavailable & minavailable#60

Open
MuriukiPM wants to merge 1 commit intokubitodev:mainfrom
cloudkite-io:fix-pdb
Open

fix(cloudflared): remove chart default pdb maxunavailable & minavailable#60
MuriukiPM wants to merge 1 commit intokubitodev:mainfrom
cloudkite-io:fix-pdb

Conversation

@MuriukiPM
Copy link
Contributor

Kubito Helm Charts PR Checklist

Thank you for your contribution! Please ensure the following:

  • Chart Version: Updated version in Chart.yaml for the relevant chart.

  • README Update: If values.yaml was changed, run:

    readme-generator -v charts/your-chart/values.yaml -r charts/your-chart/README.md

    I was unable to install this tool, but I have updated the readme manually.

  • Testing: Tested the chart locally, and it works as expected.

Changes Summary

We shouldn't set both maxunavailable & minavailable, they are mutually exclusive and will result in an error from kubernetes minAvailable and maxUnavailable cannot be both set.
Instead, we leave the default value file with null values, and let the user to set their values if they enable the pdb
e.g

cloudflared:
  podDisruptionBudget:
    enabled: true
    minAvailable: 2

Related Issues

N/A

Signed-off-by: Peter Muriuki <peter@cloudkite.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant