fix(cloudflared): remove chart default pdb maxunavailable & minavailable#60
Open
MuriukiPM wants to merge 1 commit intokubitodev:mainfrom
Open
fix(cloudflared): remove chart default pdb maxunavailable & minavailable#60MuriukiPM wants to merge 1 commit intokubitodev:mainfrom
MuriukiPM wants to merge 1 commit intokubitodev:mainfrom
Conversation
Signed-off-by: Peter Muriuki <peter@cloudkite.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kubito Helm Charts PR Checklist
Thank you for your contribution! Please ensure the following:
Chart Version: Updated
versioninChart.yamlfor the relevant chart.README Update: If
values.yamlwas changed, run:I was unable to install this tool, but I have updated the readme manually.
Testing: Tested the chart locally, and it works as expected.
Changes Summary
We shouldn't set both maxunavailable & minavailable, they are mutually exclusive and will result in an error from kubernetes
minAvailable and maxUnavailable cannot be both set.Instead, we leave the default value file with null values, and let the user to set their values if they enable the pdb
e.g
Related Issues
N/A