Added hmo logics to coverage an draw_basis#19
Conversation
and used parallel to build per_bene_mo
| from CMS_DEID.mbsf_ab_summary | ||
| unpivot( | ||
| buyin | ||
| (buyin,hmo) /*add hmo column*/ |
There was a problem hiding this comment.
I normally use a space after a comma.
There was a problem hiding this comment.
space added in new commit
| from CMS_DEID.mbsf_ab_summary | ||
| unpivot( | ||
| buyin | ||
| (buyin,hmo) /*add hmo column*/ |
There was a problem hiding this comment.
Any particular reason for the /*add hmo column*/ here? We noted that change in the commit message, right? I usually leave info about how the code changes in the version control history.
But info about how the code presently works does belong right in the code...
Maybe move the "Schroeder writes Tuesday, June 4th, 2019 6:09 PM:" stuff before this by way of explanation?
not critical.
There was a problem hiding this comment.
space added and comment removed in new commit
| from per_bene_456s | ||
| unpivot( | ||
| buyin | ||
| (buyin,hmo) /*add hmo column*/ |
There was a problem hiding this comment.
again, /*add hmo column*/ seems more like change history than documentation of the current design.
There was a problem hiding this comment.
space added and comment removed in new commit
| BENE_HMO_CVRAGE_TOT_MONS (number of months of HMO coverage for that reference year) | ||
| */ | ||
|
|
||
| select * from "&&PCORNET_CDM".enrollment; |
There was a problem hiding this comment.
This select should probably be commented out or deleted.
There was a problem hiding this comment.
removed the select statement in new commit
| from per_bene_456s | ||
| unpivot( | ||
| buyin | ||
| (buyin,hmo) /*add hmo column*/ |
There was a problem hiding this comment.
space added and comment removed in new commit
| , bene_mdcr_entlmt_buyin_ind_10 as 10 | ||
| , bene_mdcr_entlmt_buyin_ind_11 as 11 | ||
| , bene_mdcr_entlmt_buyin_ind_12 as 12 | ||
| (bene_mdcr_entlmt_buyin_ind_01,bene_hmo_ind_01) as 1 |
| , mdcr_entlmt_buyin_ind_10 as 10 | ||
| , mdcr_entlmt_buyin_ind_11 as 11 | ||
| , mdcr_entlmt_buyin_ind_12 as 12 | ||
| (mdcr_entlmt_buyin_ind_01,hmo_ind_01) as 1 |
There was a problem hiding this comment.
space added in new commit
| 'A', 'A', | ||
| 'B', 'B', | ||
| 'C', 'AB') coverage | ||
| case when hmo = '0' and buyin in ('1','A') then 'A' |
There was a problem hiding this comment.
space added in new commit
|
Looks good over all; let's stand by to see that Mary is satisfied before merging. If adding spaces after commas is not too much trouble, please do. |
add space after comma and remove unnecessary comments
another round of adding space after comma and removing unnecessary comments
adding space after comma and remove a line of "select" statement
2 participants
and used parallel to build per_bene_mo
@dckc what do you think?