add pcornet_init dependency to pcornet_loader to clear cdm_status#124
Open
nihr43 wants to merge 1 commit into
Open
add pcornet_init dependency to pcornet_loader to clear cdm_status#124nihr43 wants to merge 1 commit into
nihr43 wants to merge 1 commit into
Conversation
|
I'm pretty sure we don't want to add this requirement. Can we just run The right way to do this would be to add parameters that make it clear when things really need to run. In some cases, I have even added a design-version parameter; when I change that parameter, everything downstream gets updated. |
dckc
suggested changes
Jun 3, 2020
dckc
left a comment
dckc
left a comment
There was a problem hiding this comment.
I don't think this is a useful direction
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
not sure if we indeed want
pcornet_initto run in every instance ofpcornet_loader, but it promises to clear thecdm_statuswhich i need for COVID cdm