Refiner: Replace custom tilde expansion in doctor orchestrator with expand_user_path - #1858
Conversation
…xpand_user_path Co-authored-by: kunkunGames <271022317+kunkunGames@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Co-authored-by: kunkunGames <271022317+kunkunGames@users.noreply.github.com>
Co-authored-by: kunkunGames <271022317+kunkunGames@users.noreply.github.com>
Co-authored-by: kunkunGames <271022317+kunkunGames@users.noreply.github.com>
Co-authored-by: kunkunGames <271022317+kunkunGames@users.noreply.github.com>
Co-authored-by: kunkunGames <271022317+kunkunGames@users.noreply.github.com>
What changed: Replaced custom manual tilde expansion in src/cli/doctor/orchestrator.rs with crate::runtime_layout::expand_user_path.
Why: PR #212 replaced duplicate tilde expansion with expand_user_path. As part of Refiner, this replaces custom tilde expansion while strictly guarding with starts_with('~') to preserve byte-for-byte equivalence for non-tilde paths.
WorkFingerprint:
Agent: Refiner
Category: refactor
Primary files: src/cli/doctor/orchestrator.rs
Invariant protected: behavior-preserving, fallback behavior for non-tilde paths stays byte-for-byte equivalent.
Public API impact: None
Docs impact: None
Verification plan: cargo check --all-targets, git diff --check
Related PRs/issues: None
Duplicate/overlap check: Verified using gh/git no overlapping PRs before starting.
Verification commands and results:
cargo check --all-targets (Passed)
git diff --check (Passed)
Skipped checks with reasons: No docs generated as no docs changed.
Risk: Low. Behavior is strictly preserved via the guard check.
Rollback notes: Revert the commit.
PR created automatically by Jules for task 7826566335044703753 started by @kunkunGames