Accessor: Add id prop to EmojiPicker and connect labels - #1863
Accessor: Add id prop to EmojiPicker and connect labels#1863kunkunGames wants to merge 4 commits into
Conversation
Co-authored-by: kunkunGames <271022317+kunkunGames@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Co-authored-by: kunkunGames <271022317+kunkunGames@users.noreply.github.com>
Co-authored-by: kunkunGames <271022317+kunkunGames@users.noreply.github.com>
Co-authored-by: kunkunGames <271022317+kunkunGames@users.noreply.github.com>
What changed:
Added an
idprop to the custom<EmojiPicker>component interface and passed it down to the underlying trigger<button>. AddedhtmlForproperties to the "Emoji" and "Icon" labels inAgentFormModalandDepartmentFormModal, connecting them to the picker via the newidprop.Why:
To improve dashboard accessibility. Screen readers can now properly announce the input context for the emoji/icon picker, and clicking the label will correctly set focus on the picker button, adhering to the repository's
htmlForconnectivity guidelines.WorkFingerprint:
./scripts/verify-dashboard.shandnpm run testfor EmojiPicker tests.Duplicate/Overlap Check:
Ran
git fetch --all && git branch -aand verified there are no overlapping open PRs specifically addressing this isolatedhtmlForandidmapping for theEmojiPicker. Previous PRs attempting modal accessibility either addressed different selectors or were closed due to branch contamination (e.g., #196, #202).Verification Commands & Results:
./scripts/verify-dashboard.sh: Passed (318 tests passed across 51 files, vite build successful).cd dashboard && npm test -- src/components/agent-manager/EmojiPicker.test.tsx: Passed (3 tests passed).Skipped Checks:
ghCLI was unavailable for PR inspection, sogit fetch --all && git branch -awas used as a fallback.cargo checkandnpm run test:policieswere skipped as the boundary is strictlydashboard/src/**.Risk & Rollback Notes:
Risk is extremely low. These are pure React prop additions and HTML attribute insertions (
id,htmlFor). If regressions occur, rolling back the PR will cleanly revert the attributes without affecting state management.PR created automatically by Jules for task 1031976523699749218 started by @kunkunGames