Repository navigation
Fill-enclosed nudge + v0.5.1 - #15
Merged
Merged
Conversation
Logos whose blank interiors (letter shapes, outlined marks) match the background
print hollow unless "Fill enclosed areas" is on — but that toggle is off by
default and easy to miss. Now detection reports the enclosed-area percentage, and
when it's significant (>=5%) the GUI shows a nudge right by the toggle
("...otherwise they'll print hollow") with a one-click "Turn on".
- service.detect_from_path returns enclosedPct.
- app.jsx shows the nudge when !fillHoles && enclosedPct >= 5%.
- tests for enclosedPct (69 tests total).
Release prep: bump to 0.5.1 and finalize the CHANGELOG (also rolls up the
buy-me-a-coffee link merged earlier).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevents the "white parts print hollow" surprise: logos whose blank interiors (letter shapes, outlined marks) match the background need Fill enclosed areas, but that toggle is off by default and easy to miss.
Now detection reports how much of the design is enclosed blank area, and when it's significant (≥5%) the GUI shows a nudge right by the toggle — "This logo has large blank areas inside it (~36%). Turn this on to paint them — otherwise they'll print hollow." — with a one-click Turn on.
service.detect_from_pathreturnsenclosedPct.app.jsxrenders the nudge when!fillHoles && enclosedPct >= 5%.enclosedPct. Full suite: 69 passing.Verified live in a headless browser on the real logo: nudge shows "~36%", clicking Turn on enables fill (White appears) and dismisses the nudge; no console errors. Ships as v0.5.1 (also rolls up the buy-me-a-coffee link). Auto-deploys on merge.
🤖 Generated with Claude Code