Repository navigation
Share session detail reads and reconcile interrupts from ranged reads - #2904
Draft
nortonandreev wants to merge 4 commits into
Draft
nortonandreev wants to merge 4 commits into
nortonandreev wants to merge 4 commits into
Conversation
…#2729) A first reconcile still folds the stream from its first event: no route lists pending interrupts, and one issued before any tail window stays pending until resolved.
…#2729) The listing's word is not kept: a session it shows ended can be resumed, and only the stream and summary are final.
…2729) A session resumes under the same id, so an end only clears what was pending. The server's next_from counts events it withholds from the viewer, so it is followed past empty pages.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
|
Qodana for .NET3 new problems were found
💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at qodana-support@jetbrains.com
|
This was referenced Nov 18, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2729 — AI-5619
What & why
Opening a session read
/detailtwice, the session's full event list both times, and/artefactsand/plan-artifactstwice each. Callers now share one in-flight detail read, and interrupt reconciliation reads/eventsin ranges instead of the full detail. The large-session open receives half the bytes it did.Where to look
SessionInterruptLog: a session resumes under the same id, so an end clears only what is pending. The server'snext_fromcounts events it withholds from the viewer, so reads follow it past empty pages.ArtefactsTabViewModel.RefreshUnlessReadyre-reads when a grant arrives while a read is in flight.Verification
Tart VM (macOS 26, 4 vCPU, 4 GB), local server, 13,505-event session, cold restart then 20 s idle,
tools/app-perf/capture_open.sh(#2896), one run each:/detailrequests/artefacts,/plan-artifacts