Repository navigation
Read app-state.json once at start for the settings and first window - #2905
Draft
nortonandreev wants to merge 1 commit into
Draft
nortonandreev wants to merge 1 commit into
nortonandreev wants to merge 1 commit into
Conversation
…2734) The first main window takes the constructor's snapshot; a later window or one after setup reads afresh, since an earlier window may have saved geometry or rail preferences since.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
|
Qodana for .NET1 new problem were found
💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at qodana-support@jetbrains.com
|
1 task
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2734 — AI-5624
What & why
Start-up read
app-state.jsononce each for the UI scale, beta updates, rail preferences and the first window. It now reads it once, in theAppconstructor, and hands that snapshot to each. This is the "single state read" part of the issue. Trimming and ReadyToRun are reported on the issue.Where to look
Only the first main window takes the constructor's snapshot. A later window, or one opened after setup, reads the file again, because an earlier window may have saved geometry or rail preferences since.
Verification
Tart VM (macOS 26, 4 vCPU, 4 GB),
tools/app-perf/coldstart_ab.sh(#2896), 6 rounds alternating builds:The screen-time difference is within this guest's run-to-run spread. No start-up gain was measured.