Skip to content

Show the main window's frame before the daemon graph is built - #2906

Draft
nortonandreev wants to merge 3 commits into
kcap-2732-startup-marksfrom
kcap-2733-early-window
Draft

nortonandreev wants to merge 3 commits into
kcap-2732-startup-marksfrom
kcap-2733-early-window

Conversation

@nortonandreev

Copy link
Copy Markdown
Contributor

Closes #2733 — AI-5623

Stacked on #2900 (#2732): the start-up marks are what this change is timed with.

What & why

The main window appeared only after the daemon graph was built. A frame with no view model is now shown as soon as the saved window state is read, and the graph's window factory adopts it in place, so the user sees the window at its saved size and position while the graph builds. A launch that is finishing an update still shows its progress first.

Where to look

The frame is tracked before its first Show(): the platform resizes a window restored maximized at that point, and a tracker attached afterwards would save the work area as the normal frame. A quit during the frame's wait builds nothing. A minimized frame is adopted without being restored or activated.

Verification

Tart VM (macOS 26, 4 vCPU, 4 GB), tools/app-perf/coldstart_ab.sh (#2896), 6 rounds alternating builds:

main #2900 this branch
window_shown mark, median 2,030 ms 1,954 ms
Window on screen (OCR), median 2.26 s 2.27 s 2.81 s
Session rows on screen (OCR), median 2.68 s 2.60 s 2.89 s

No gain measured on screen in this guest. The mark moves earlier, but OCR reads the frame later.

The frame carries no view model, since every surface binding needs one; the graph's window
factory adopts it in place. A launch finishing an update still shows its progress first.
A window restored maximized is resized by the platform on Show(); a tracker attached after
that seeds its normal frame from the work area and saves it on quit.
… quit (#2733)

Showing the adopted frame through the coordinator restored a minimized window and activated it;
a quit during the frame's wait no longer throws, so the graph build itself checks for one.
@coderabbitai

coderabbitai Bot commented Nov 18, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@github-actions

Copy link
Copy Markdown

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant