Repository navigation
Show the main window's frame before the daemon graph is built - #2906
Draft
nortonandreev wants to merge 3 commits into
Draft
nortonandreev wants to merge 3 commits into
nortonandreev wants to merge 3 commits into
Conversation
The frame carries no view model, since every surface binding needs one; the graph's window factory adopts it in place. A launch finishing an update still shows its progress first.
A window restored maximized is resized by the platform on Show(); a tracker attached after that seeds its normal frame from the work area and saves it on quit.
… quit (#2733) Showing the adopted frame through the coordinator restored a minimized window and activated it; a quit during the frame's wait no longer throws, so the graph build itself checks for one.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
|
Qodana for .NETIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at qodana-support@jetbrains.com
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2733 — AI-5623
Stacked on #2900 (#2732): the start-up marks are what this change is timed with.
What & why
The main window appeared only after the daemon graph was built. A frame with no view model is now shown as soon as the saved window state is read, and the graph's window factory adopts it in place, so the user sees the window at its saved size and position while the graph builds. A launch that is finishing an update still shows its progress first.
Where to look
The frame is tracked before its first
Show(): the platform resizes a window restored maximized at that point, and a tracker attached afterwards would save the work area as the normal frame. A quit during the frame's wait builds nothing. A minimized frame is adopted without being restored or activated.Verification
Tart VM (macOS 26, 4 vCPU, 4 GB),
tools/app-perf/coldstart_ab.sh(#2896), 6 rounds alternating builds:window_shownmark, medianNo gain measured on screen in this guest. The mark moves earlier, but OCR reads the frame later.