Skip to content

Share anything by object key through kcap sharing and kcap-sharing - #2907

Draft
Inok wants to merge 1 commit into
mainfrom
pavel/ai-5716-page-sharing
Draft

Inok wants to merge 1 commit into
mainfrom
pavel/ai-5716-page-sharing

Conversation

@Inok

@Inok Inok commented Nov 18, 2026 •

Copy link
Copy Markdown
Member

AI-5716 (no GitHub issue)

What & why

kcap-server#3240 moves sharing to one public API keyed by an opaque object key. kcap now shares through it, one grant at a time, with a new kcap-sharing MCP server (list_sharing_grants, search_sharing_candidates, set_sharing_grant, remove_sharing_grant) and kcap sharing list|candidates|set|remove. Neither knows an entity type: the key comes from the record the server sends, so sessions or anything else the server makes shareable need no client change. Publishing a page no longer shares it and refuses an audience; page records show object_key and who they are shared with.

Where to look

  • A server too old to send object_key cannot share from kcap; the pages server's instructions send the user to the web app.
  • Keys are escaped as one path segment each; . and .. are refused.
  • kcap-sharing is not auto-approved and both its writes are annotated destructive, so annotation-driven harnesses prompt for them; its two read tools skip Claude's auto-mode classifier, and their results carry the untrusted-content notice.

Verification

  • dotnet build Capacitor.slnx: 0 errors after rebasing on main.
  • Unit suites: CLI 9,072, Core 7,806, App 7,610, SourceGuards 80. Two failures passed on rerun alone: a hook permission-record test and the agent-attach concurrent-losers test.
  • AOT publish: no IL warnings; the binary lists the four sharing tools.

🤖 Generated with Claude Code

@linear-code

linear-code Bot commented Nov 18, 2026

Copy link
Copy Markdown

AI-5716

@coderabbitai

coderabbitai Bot commented Nov 18, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@github-actions

Copy link
Copy Markdown

Qodana for .NET

5 new problems were found

Inspection name Severity Problems
Convert 'if' statement into 'switch' ◽️ Notice 2
Escape sequence can be simplified ◽️ Notice 2
'if-return' statement can be rewritten as 'return' statement ◽️ Notice 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

…sharing

Nothing here knows an entity type or builds a key: the object key comes from the record the server sends,
so a type it makes shareable later needs no client change. A server too old to send one is shared from the web app.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@Inok
Inok force-pushed the pavel/ai-5716-page-sharing branch from 236032b to fba58fe Compare November 18, 2026 14:39

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant