Fix loading OpenJDK 21 keystores that do not have algo parameters#82
Open
maxnet wants to merge 1 commit into
Open
Fix loading OpenJDK 21 keystores that do not have algo parameters#82maxnet wants to merge 1 commit into
maxnet wants to merge 1 commit into
Conversation
|
Can someone please merge this pull request? This fix works and needs to be implemented. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
algo parameters are not set with newer keytool/jdk versions.
we do query them, resulting in an "pyasn1.error.PyAsn1Error: Attempted "index" operation on ASN.1 schema object" error.
They are not used by the code when algo_id == SUN_JKS_ALGO_ID, so we do not need them in that case.
Only used when algo_id == SUN_JCE_ALGO_ID, so move the code that queries them to that section
Closes #79