Skip to content

Use HTTPS repository metadata - #74

Open
Soengkit wants to merge 1 commit into
kurttheviking:masterfrom
Soengkit:codex/use-https-repository-metadata
Open

Soengkit wants to merge 1 commit into
kurttheviking:masterfrom
Soengkit:codex/use-https-repository-metadata

Conversation

@Soengkit

Copy link
Copy Markdown

Summary

  • update the package repository metadata to use the public git+https:// GitHub URL
  • leave runtime code, dependencies, version, and package entrypoints unchanged

Why

The published npm metadata for git-rev-sync@3.0.2 currently resolves to an SSH GitHub URL:

git+ssh://git@github.com/kurttheviking/git-rev-sync-js.git

The default-branch package.json stores the same public repository as an SCP-style SSH URL:

git@github.com:kurttheviking/git-rev-sync-js.git

Public package metadata should be usable by consumers and tooling without GitHub SSH credentials, so this changes the source manifest to:

git+https://github.com/kurttheviking/git-rev-sync-js.git

Validation

node -e "const p=require('./package.json'); if (p.repository.url !== 'git+https://github.com/kurttheviking/git-rev-sync-js.git') { console.error(p.repository); process.exit(1) } console.log(JSON.stringify({name:p.name, version:p.version, repository:p.repository, license:p.license}, null, 2))"
git diff --check

I also tried node tests/index, but this checkout does not have dependencies installed and the current shell/runtime does not provide npm; the command stopped before running tests with Cannot find module 'escape-string-regexp'. The submitted change is limited to valid package.json metadata.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant