Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
git+https://GitHub URLWhy
The published npm metadata for
git-rev-sync@3.0.2currently resolves to an SSH GitHub URL:The default-branch
package.jsonstores the same public repository as an SCP-style SSH URL:Public package metadata should be usable by consumers and tooling without GitHub SSH credentials, so this changes the source manifest to:
Validation
node -e "const p=require('./package.json'); if (p.repository.url !== 'git+https://github.com/kurttheviking/git-rev-sync-js.git') { console.error(p.repository); process.exit(1) } console.log(JSON.stringify({name:p.name, version:p.version, repository:p.repository, license:p.license}, null, 2))" git diff --checkI also tried
node tests/index, but this checkout does not have dependencies installed and the current shell/runtime does not providenpm; the command stopped before running tests withCannot find module 'escape-string-regexp'. The submitted change is limited to validpackage.jsonmetadata.