Repository navigation
perf(users): load other strategies' credentials on expand - #1251
Merged
Merged
Conversation
The users list took several seconds to open on a remote backend: it called getCredentials for every user and every strategy, sequentially. It now only loads `local`, the only one shown on a folded row, in parallel; UserItem loads every strategy when first expanded. Backport of #1250 (G-132). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
✅ Deploy Preview for heuristic-goodall-67c4b1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #1250 (QA feedback on console-v5, the code comes from v4).
Cause:
performSearchUserscalledgetCredentialsfor every user × strategy, sequentially (2 + 25 × 2 round trips for 25 users and two strategies) — several seconds on a remote backend, invisible locally.Fix
local(the only one shown on a folded row), in parallel, andgetStrategiesalongside the search.UserItemloads every strategy on first expand (getUserCredentials).usersspec: expanding renders the credentials.Checked against a build on a fresh stack:
users21/21.test:typeshas the same 6 pre-existing errors as4-dev, none in the touched files.🤖 Generated with Claude Code