Repository navigation
ci: functional tests no longer wait for unit tests; container npm cache - #2941
Merged
Merged
Conversation
- functional-tests needs only `build`. The unit tests sat on the critical path (~2.5 min) for a gate the functional jobs do not use. - The containerised `npm ci` of the functional and monkey jobs mounts the runner's ~/.npm — which setup-node (`cache: "npm"`) already restores from the lockfile-keyed cache, and which nothing used — as the container's npm cache, with --prefer-offline: tarballs come from disk, not the registry. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
|
🎉 This PR is included in version 2.57.0-beta.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.57.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two of the CI levers measured after #2938.
What
functional-testsneeds onlybuild(was[build, unit-tests]). The unit tests were on the critical path — lint 0.8 min → unit ~2 min → functional — for a gate the functional jobs do not use. Trade-off: a unit-test failure no longer spares the 30 functional jobs.~/.npmthroughsetup-node(cache: "npm", keyed by the lockfile), but thenpm cithat runs inside the test-cluster container never used it.run-test-cluster.sh/run-monkey-tests.shnow mountNPM_CACHE_DIR(the runner's~/.npm, set by the actions) as the container's npm cache (/var/npm, the image'sNPM_CONFIG_CACHE) and runnpm ci --prefer-offline. UnsetNPM_CACHE_DIR(local runs) → unchanged behavior.Measurement
Before/after figures for this PR's own run are posted as a comment once it completes (same method as the #2938 measurement: median over job/step timings of attempt 1).
🤖 Generated with Claude Code