Skip 5 seconds back, drop picture in picture - #9
Merged
Merged
Conversation
The back button undoes a line of dialogue you missed; the forward one jumps an opening. Double-tap in each zone follows its own button. Picture in picture goes with it: Gecko has no floating-window API on Android, so the button asked the system for the home screen and hoped.
Firefox for Android hands no decoded video frame to any script: a 2D canvas comes back empty, a WebGL texture reads back one flat colour, and captureVisibleTab draws the video area black.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
dialogue you missed; going forward is for the opening you have seen. A
double-tap in each zone follows its own button: 5 seconds a tap on the left,
10 on the right.
so the button asked the system for the home screen and hoped — it worked on
some builds and did nothing on others. The top row is one button shorter.
A screenshot button was attempted and is not possible
Firefox for Android does not give a decoded video frame to any script:
drawImage(video)into a 2D canvas leaves it fully transparent;#330033, edge to edge;tabs.captureVisibleTab(tried with<all_urls>) renders the page with thevideo area black.
Measured from a page's own script, from a content script and from a background
script, on Firefox 153 on an AOSP Android 16 emulator and on a Pixel 9 Pro. The
button is therefore not shipped rather than shipped broken; the limitation is
written down in the README and the changelog.
Checks
web-ext lint: 0 errors, 0 warningsstorage,activeTab)right, and both seek by those amounts