Repository navigation
Conversation
An open KeyboardPanel (clock calendar via SUPER+CTRL+ALT+D, battery, …) holds layer-shell keyboard focus. With one up, the screensaver toplevel never becomes activewindow, Hyprland skips the fullscreen windowrule, and omarchy-screensaver treats the missing focus as a dismissal ~1s later — which cancels the idle lock cycle as screensaver-dismissed. Close the active bar popout before spawning, and only treat lost focus as a dismissal after the screensaver has held focus and a short launch grace has elapsed (so multi-monitor focus hops during launch do not self-kill). Fixes omacom#13265
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Screensaver launch with an open clock calendar popup (
omarchy.clockKeyboardPanel) no longer self-dismisses as a small centered square after ~1.4s.omarchy-launch-screensavercallsomarchy-shell -q shell closeActivePopout. NewBar.closeActivePopout()+ shell IPC close whichever KeyboardPanel/PopupCard owns the single-popout slot (clock, battery, …), releasing layer-shell focus so the screensaver can becomeactivewindowand Hyprland'sfullscreenwindowrule fororg.omarchy.screensavercan apply.omarchy-screensaver— only treat missing focus as dismissal after the screensaver has actually held focus and a 3s launch grace has elapsed. Never-focused (panel still open) no longer self-kills on the first 1s poll; multi-monitor focus hops during launch also stay inside the grace window.Why
Trace from omacom#13265: with the calendar open, the screensaver maps at ~800×600 (
fullscreen=0), never gets anactivewindowevent, andomarchy-screensaverexits whenscreensaver_in_focusis false. Idle then logsscreensaver-dismissedand cancels the pending lock. Same root cause as omacom#6917 (open PR omacom#7102's latch alone); closing the panel also addresses the fullscreen half that the latch-only approach left to the compositor.Tests
test/shell.d/launch-screensaver-test.sh— focus-dismiss policy table (panel / grace / multi-monitor hop), static wiring checks, mocked launch verifyingcloseActivePopoutruns before spawn.Issue
Fixes omacom#13265