Repository navigation
fix: release managed headless writer on detach - #908
Merged
kxn merged 1 commit intoAug 31, 2026
Merged
Conversation
Owner
|
Thanks for the fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #907.
/detachcurrently clears the Feishu surface route but leaves the daemon-owned managed headlesscodex app-serveralive. That process keeps the Codex thread writer lock, so a localcodex resume <THREAD_ID>fails withalready has an active writereven after Feishu reports that the surface was detached.What changed
headless.killafter immediate detach of a managed headless instance.Tests
go test ./internal/core/orchestrator ./internal/app/daemongo test ./...scripts/check/pre-commit.shThe full test suite passes. The pre-commit guardrail prints existing repository-wide path warnings but exits successfully with
pre-commit: passed.Reproduction covered
The reported flow is now represented by regression coverage: idle detach releases the managed carrier, delayed/timeout detach releases it after finalization, and a carrier still used by another surface is retained.