docs: align tier tables, LSP membership, and ADR-0031 variant across docs#243
Merged
Merged
Conversation
Five-task TDD plan addressing stale model strings, swapped tier tables, LSP agent counts/membership, and ADR-0031 variant bump across README, CODING_HARNESS, and AGENTS.md. Refs: #186 Authored-by: glm-5.2 Tested-by: deepseek-v4-pro Signed-off-by: kyau <git@kyaulabs.com>
ADR-0031 §2 mandates variants.planner/design = max (abundant GLM quota; planning/design quality feeds downstream coding). The bump was never applied to setup.json; the guard test enforced the stale high value. Refs: #186 Authored-by: glm-5.2 Tested-by: deepseek-v4-pro Signed-off-by: kyau <git@kyaulabs.com>
explore's prompt already directs an "LSP workflow" and AGENTS.md/CONTEXT.md describe it navigating code semantically, yet its frontmatter omitted lsp: allow so it inherited the top-level deny. LSP is read-only (go-to-definition, find-references), consistent with ADR-0006. Refs: #186 Authored-by: glm-5.2 Tested-by: deepseek-v4-pro Signed-off-by: kyau <git@kyaulabs.com>
AGENTS.md said "seven" in one paragraph and "six" in another, listed explore (now correctly lsp-enabled) but omitted design. Replace the stale enumerated deny-list with a non-enumerated form; a new lsp_enabled_agents() parity test is now the authoritative guard. Refs: #186 Authored-by: glm-5.2 Tested-by: deepseek-v4-pro Signed-off-by: kyau <git@kyaulabs.com>
README/CODING_HARNESS showed Primary/Judge models swapped, used the stale openrouter/z-ai provider prefix, and listed pre-ADR-0031 agent assignments. Regenerated both tables from setup.json models/variants and opencode.jsonc tier membership; fixed the README install verify comment. Added parity tests anchoring the docs to setup.json. Refs: #186 Authored-by: glm-5.2 Tested-by: deepseek-v4-pro Signed-off-by: kyau <git@kyaulabs.com>
Refs: #186 Authored-by: glm-5.2 Tested-by: deepseek-v4-pro Signed-off-by: kyau <git@kyaulabs.com>
guard glob() false-return and unsafe permission array-key access in lsp_enabled_agents(); normalize blank lines after RCS header in ExploreAgentTest. Refs: #186 Authored-by: glm-5.2 Tested-by: deepseek-v4-pro Signed-off-by: kyau <git@kyaulabs.com>
kyau
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📋 Summary
Seven commits that together fix model/tier/LSP documentation drift across README, CODING_HARNESS, and AGENTS.md — model strings were swapped, agent-per-tier lists predated ADR-0031's reassignments, and LSP agent counts/membership were stale. Includes the deferred ADR-0031 §2 planner/design variant bump (
high→max) and grants@explorethelsp: allowpermission its own prompt already expects. New parity guard tests anchor the docs to the shipped config so future drift fails CI.📦 Changes by Phase
Phase A — Config (behavior)
.opencode/setup.json— planner/design varianthigh→max(ADR-0031 §2).opencode/agents/explore.md— addedlsp: allowpermissionModelConfigTest— flipped variant assertion tomax;ExploreAgentTest— new test forlsp: allowPhase B — AGENTS.md LSP section
AGENTS.md— LSP count → 8, membership includesdesign+explore, stale deny-list replacedlsp_enabled_agents()parity test inModelConfigTestPhase C — README + CODING_HARNESS tier tables
README.md— tier table regenerated from setup.json, verify comment fixedCODING_HARNESS.md— tier table with variant column (maxfor planner/design,mediumfor judge/utility); also fixed a stalehighprose referenceModelConfigTestPhase D — LSP docs sweep
.opencode/docs/lsp.md— added missingdesignrow to permissions tablePhase E — Code-review fixes
ModelConfigTest— guardedglob()false-return and unsafe array-key accessExploreAgentTest— normalized excess blank lines after RCS header📜 ADRs
✅ Verification
Good signature from kyau)🏗️ Architect Conditions
Not applicable — the changes were validated against an Accepted ADR (ADR-0031) and the issue was triaged via
@from-issuewith three grilling rounds. No separate architect review was needed.📝 Commits (7)
4026e89docs(plan)50909b9chore(config)maxper ADR-003104d2897fix(explore)@explorelsp: allow3cc0d63docs(agents)226f436docs8953333docs(lsp)555a03ctest🧪 Test Plan
cd prism && php vendor/bin/pest --filter 'ModelConfigTest|ExploreAgentTest'— all 35 passphp vendor/bin/php-cs-fixer fix --dry-run --diff— cleanecho $OPENCODE_MODEL_PRIMARY—zai-coding-plan/glm-5.2CODING_HARNESS.md— verify planner/design variant column showsmaxFixes: #186