Drop the "Where" masthead and float the home toolbar over the cards#63
Merged
Conversation
The Primary tab's gold-foil "Where" wordmark (PassportMasthead) sat pinned above the cards, eating vertical space and blocking them from scrolling to the top. Remove it and make `screen` the NavigationStack's direct content so the glass cards scroll under a transparent nav bar, with `.toolbarBackground(.hidden)` letting the trailing toolbar buttons float over the content. Keep the TiltProvider (region cards still use its sheen) and delete the now-unused primaryTitle string and mastheadFontSize constant. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PassportMasthead) sat pinned above the cards, eating vertical space and blocking them from scrolling to the top. It was a custom design element, not a nav-bar title.screentheNavigationStack's direct content so the glass cards scroll under a transparent nav bar;.toolbarBackground(.hidden, for: .navigationBar)lets the trailing toolbar buttons (timeline / calendar / year selector) float over the scrolling content.TiltProviderand its lifecycle —RegionSummaryCardstill uses its tilt-reactive sheen — and deleted the now-unusedStrings.primaryTitlestring (+primary.titlecatalog entry) andUIConstants.Size.mastheadFontSizeconstant.The dark passport-cover gradient still fills behind the bar (the
LinearGradientbackground ignores safe-area edges) and the forced-dark toolbar color scheme keeps the buttons legible.Test plan
./swiftformat --lint .— cleantuist test Stuff-iOS-Tests— full iOS suite passes (incl.StringsTests)Made with Cursor