can not auto-reconnect

[AaronJan]

Describe the issue

First of all, great project! 👍

When client connected to a server, force exit the server and restart a new server, then the client seems to entered an infinity loop, it can never do a successful handshake with the new server, just keep reconnecting.

and when this happening, the client leak the NodeMessage for handshake as an message event, so I keep getting a handshake message on every reconnecting.

Code or steps to reproduce

Server:

import { Server } from 'veza';

async function main(): Promise<void> {
  const name = 'my_server';
  console.log('name', name);

  const server = new Server(name);
  await server.listen({
    host: '127.0.0.1',
    port: 11122,
  });
  setInterval(async () => {
    console.log('broadcast!', server.sockets.size);
    await server.broadcast({ hello: 'world' });
  }, 2000);
}

main();

Client:

import { Client } from 'veza';

async function main(): Promise<void> {
  const name = 'my_client';
  console.log('name', name);

  const client = new Client(name);
  client.on('message', message => {
    // Shouldn't get a handshake message in here.
    console.log('message!', message);
    message.reply({ world: 'hello' });
  });
  await client.connectTo({
    host: '127.0.0.1',
    port: 11122,
  });
}

main();

1. start server
2. start client
3. ctrl+c stop the server
4. restart server

Expected and actual behavior

• The client should reconnect with the new server
• The client's message event should be emitted with a handshake message

Further details

• node.js version: 13.2.0
• veza version: 1.1.0
• I have tested the issue on latest master. Commit hash:

[kyranet]

It's possible the behaviour of Node.js's net module changed with v13, I'll have to check, and while I'm at it, check why Dependabot's PRs are red.

But yes, your expected behaviour is also the one I expected, I believe I have a test just for that:

veza/test/handshake.test.ts

Lines 240 to 294 in 82a5765

	test('Socket Connection Retries (Successful Reconnect)', { timeout: 7500 }, async t => {
	t.plan(4);
	const [nodeServer, nodeSocket] = await setup(t, ++port, { maximumRetries: 3, retryTime: 200 });
	await nodeServer.close();
	nodeSocket.once('connecting', () => {
	t.pass('Reconnecting event fired.');
	next();
	});
	async function next() {
	nodeSocket
	.once('connect', () => t.pass('Socket fired connect'))
	.once('ready', () => t.pass('Socket fired Ready'));
	await nodeServer.listen(port);
	await new Promise(resolve => {
	nodeServer.once('connect', resolve);
	});
	t.pass('Successfully reconnected the server.');
	await nodeServer.close();
	nodeSocket.disconnectFrom('Server');
	}
	});
	test('Socket Connection Retries (Successful Reconnect | Different Name)', { timeout: 7500 }, async t => {
	t.plan(8);
	const [nodeServerFirst, nodeSocket] = await setup(t, ++port, { maximumRetries: 3, retryTime: 200 });
	const socketServer = nodeSocket.get('Server')!;
	t.equal(socketServer.name, 'Server', 'The Server should be "Server".');
	// Disconnect and set up a second server with a different name
	await nodeServerFirst.close();
	const nodeServerSecond = new Server('NewServer');
	nodeSocket.once('connecting', async () => {
	t.pass('Reconnecting event fired.');
	nodeSocket
	.once('connect', () => t.pass('Socket fired connect'))
	.once('ready', () => t.pass('Socket fired Ready'));
	await nodeServerSecond.listen(port);
	await new Promise(resolve => {
	nodeServerSecond.once('connect', resolve);
	});
	t.pass('Successfully reconnected the server.');
	t.equal(nodeSocket.get('Server'), null, 'Since the name of the server has changed, the key "Server" should be null.');
	t.equal(nodeSocket.get('NewServer'), socketServer, 'The socket should be available under the key "NewServer".');
	t.equal(socketServer.name, 'NewServer', 'The name for the socket should be changed to "NewServer".');
	await nodeServerSecond.close();
	nodeSocket.disconnectFrom('NewServer');
	});
	});

Also, what happens if you only pass a port to connectTo and serve? server.listen(11122); and client.connectTo(11122); for instance.

[AaronJan]

It's possible the behaviour of Node.js's net module changed with v13, I'll have to check, and while I'm at it, check why Dependabot's PRs are red.

But yes, your expected behaviour is also the one I expected, I believe I have a test just for that:

veza/test/handshake.test.ts

Lines 240 to 294 in 82a5765

	test('Socket Connection Retries (Successful Reconnect)', { timeout: 7500 }, async t => {
	t.plan(4);
	const [nodeServer, nodeSocket] = await setup(t, ++port, { maximumRetries: 3, retryTime: 200 });
	await nodeServer.close();
	nodeSocket.once('connecting', () => {
	t.pass('Reconnecting event fired.');
	next();
	});
	async function next() {
	nodeSocket
	.once('connect', () => t.pass('Socket fired connect'))
	.once('ready', () => t.pass('Socket fired Ready'));
	await nodeServer.listen(port);
	await new Promise(resolve => {
	nodeServer.once('connect', resolve);
	});
	t.pass('Successfully reconnected the server.');
	await nodeServer.close();
	nodeSocket.disconnectFrom('Server');
	}
	});
	test('Socket Connection Retries (Successful Reconnect | Different Name)', { timeout: 7500 }, async t => {
	t.plan(8);
	const [nodeServerFirst, nodeSocket] = await setup(t, ++port, { maximumRetries: 3, retryTime: 200 });
	const socketServer = nodeSocket.get('Server')!;
	t.equal(socketServer.name, 'Server', 'The Server should be "Server".');
	// Disconnect and set up a second server with a different name
	await nodeServerFirst.close();
	const nodeServerSecond = new Server('NewServer');
	nodeSocket.once('connecting', async () => {
	t.pass('Reconnecting event fired.');
	nodeSocket
	.once('connect', () => t.pass('Socket fired connect'))
	.once('ready', () => t.pass('Socket fired Ready'));
	await nodeServerSecond.listen(port);
	await new Promise(resolve => {
	nodeServerSecond.once('connect', resolve);
	});
	t.pass('Successfully reconnected the server.');
	t.equal(nodeSocket.get('Server'), null, 'Since the name of the server has changed, the key "Server" should be null.');
	t.equal(nodeSocket.get('NewServer'), socketServer, 'The socket should be available under the key "NewServer".');
	t.equal(socketServer.name, 'NewServer', 'The name for the socket should be changed to "NewServer".');
	await nodeServerSecond.close();
	nodeSocket.disconnectFrom('NewServer');
	});
	});

Also, what happens if you only pass a port to connectTo and serve? server.listen(11122); and client.connectTo(11122); for instance.

Thank you for the quick reply!

I tested it by only pass a port to both server and client, it didn't work, still the same.