Instances import

[Leo-Marbehan]

Instances import

To do

• Merge Feedback on HTTP events #188 before.
• Rebase on master.

Modifications

• Add multiple instances import (import a folder of instances folder).
• Add instance delete.
• Add autocomplete on instance field when starting a simulation.

Visuals

[Leo-Marbehan]

I deployed the latest version to TestPyPI. If you want you can install it and test it :

python -m pip install --index-url https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple multimodalsim-viewer==0.1.5.0

[pamun1]

I tested the importation of multiple instances and it works well. I was wondering if, in addition to letting users import a folder of instance folders, it would be a good idea to let users select only the instance folders that they want to import (i.e., by clicking on multiple folders with Ctrl or Shift). I think this might be useful if a folder contains a lot a instance folders and the user does not want to import them all. Maybe this could be done later (in a different pull request).

[pamun1]

I was not able to test the "autocomplete on instance field when starting a simulation". How does it work? What should be autocompleted? The "Data" field in the "Configure Simulation" form?

[pamun1]

It looks good overall. I tested the new functionalities and they appear to be working as expected. However, I was not able to test the autocompletion feature. Please have a look at my comments.

[Leo-Marbehan]

I tested the importation of multiple instances and it works well. I was wondering if, in addition to letting users import a folder of instance folders, it would be a good idea to let users select only the instance folders that they want to import (i.e., by clicking on multiple folders with Ctrl or Shift). I think this might be useful if a folder contains a lot a instance folders and the user does not want to import them all. Maybe this could be done later (in a different pull request).

I think that there is currently no way to upload multiple folders. It works for directories but not folders. Alternatively we can provide a multi-file import for compressed instances folder.

Or another idea would be to allow the user to select the folder with all instances, and then filter which ones will be imported in a dedicated interface.

[Leo-Marbehan]

I was not able to test the "autocomplete on instance field when starting a simulation". How does it work? What should be autocompleted? The "Data" field in the "Configure Simulation" form?

The name "autocomplete" might be misleading. The feature is that you can type in the "Data" field and the instances are filtered. I did it using Angular Material and you can read about it here.

[pamun1]

I think the way the importation works is fine for now. The ideas that you suggested are good. Maybe we can look at them later.

As for the "autocomplete" feature, I see what you mean now. It seems to be working fine.

[pamun1]

Thank you for the explanations. Everything looks good.