Ng unreacheable

.github/workflows/benchmark.yml

@@ -0,0 +1,80 @@
+name: Benchmark
+
+on:
+  workflow_dispatch:
+    inputs:
+      max_instances:
+        description: 'Instances per family for small benchmark (1–9; default 2)'
+        default: '2'
+        required: true
+        type: string
+      run_large:
+        description: 'Also run large benchmark (C2/R2/RC2)'
+        type: boolean
+        default: false
+      max_large_instances:
+        description: 'Instances per family for large benchmark (1–8; R2 up to 11)'
+        default: '2'
+        required: false
+        type: string
+
+env:
+  FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: true
+
+defaults:
+  run:
+    shell: bash
+
+jobs:
+  benchmark:
+    name: Benchmark / ubuntu
+    # NOTE: Gurobi must be installed on the runner and GUROBI_HOME must be set.
+    # Use a self-hosted runner with Gurobi, or adjust the "Install Gurobi" step.
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@v4
+        with:
+          submodules: recursive
+          lfs: true
+
+      - name: Install build dependencies
+        run: sudo apt-get update -q && sudo apt-get install -y build-essential cmake
+
+      - name: Configure (Release, no Python, no tests)
+        run: |
+          cmake -B build \
+            -DCMAKE_BUILD_TYPE=Release \
+            -DUSE_PYTHON=OFF \
+            -DUSE_TESTS=OFF
+
+      - name: Build small benchmark
+        run: cmake --build build --target rcspp-vrp-benchmark --parallel
+
+      - name: Build large benchmark
+        if: inputs.run_large
+        run: cmake --build build --target rcspp-vrp-benchmark-large --parallel
+
+      - name: Run small benchmark (C1/R1/RC1)
+        run: |
+          ./build/bin/rcspp-vrp-benchmark ${{ inputs.max_instances }} \
+            2>&1 | tee benchmark_small.txt
+
+      - name: Run large benchmark (C2/R2/RC2)
+        if: inputs.run_large
+        run: |
+          ./build/bin/rcspp-vrp-benchmark-large ${{ inputs.max_large_instances }} \
+            2>&1 | tee benchmark_large.txt
+
+      - name: Upload small benchmark results
+        uses: actions/upload-artifact@v4
+        with:
+          name: benchmark-small-${{ github.sha }}
+          path: benchmark_small.txt
+
+      - name: Upload large benchmark results
+        if: inputs.run_large
+        uses: actions/upload-artifact@v4
+        with:
+          name: benchmark-large-${{ github.sha }}
+          path: benchmark_large.txt

.github/workflows/ci.yml

@@ -16,13 +16,20 @@ defaults:
 
 jobs:
   test:
-    name: Test / ${{ matrix.os }} / ${{ matrix.build-type }}
+    name: Test / ${{ matrix.os }} / ${{ matrix.build-type }} / py${{ matrix.python-version }}
     runs-on: ${{ matrix.os }}
     strategy:
       fail-fast: false
       matrix:
         os: [ubuntu-latest, macos-latest, windows-latest]
         build-type: [Debug, Release]
+        python-version: ['3.11', '3.12', '3.13']
+        exclude:
+          # Debug builds don't run Python tests — only one Python version needed
+          - build-type: Debug
+            python-version: '3.11'
+          - build-type: Debug
+            python-version: '3.13'
 
     steps:
       - uses: actions/checkout@v4
@@ -42,7 +49,7 @@ jobs:
 
       - uses: actions/setup-python@v5
         with:
-          python-version: '3.12'
+          python-version: ${{ matrix.python-version }}
 
       - name: Configure
         run: cmake -B build -DCMAKE_BUILD_TYPE=${{ matrix.build-type }} -DUSE_PYTHON=ON -DUSE_TESTS=ON
@@ -60,7 +67,7 @@ jobs:
       - name: Python tests
         if: matrix.build-type == 'Release'
         working-directory: src/python
-        run: pytest -v
+        run: pytest -v --tb=short
 
   build_wheels:
     name: Wheels / ${{ matrix.os }}

.gitignore

@@ -1,6 +1,10 @@
 .vs/*
+.cache/*
 out/*
-build/*
+build/
+build_*/
+cmake-build-*/
+**/__pycache__/**
 *.dll
 *.lib
 *.exp
@@ -9,8 +13,23 @@ build/*
 *.o
 *.a
 *.exe
+*.so
+*.dylib
 instances/duals/
 
+# Python
+.venv/
+.venv-*/
+venv/
+.pytest_cache/
+__pycache__/
+*.py[cod]
+*.pyd
+*.egg-info/
+dist/
+wheelhouse/
+build-*/
+
 # CMake / Ninja generated files
 CMakeCache.txt
 CMakeFiles/
@@ -37,3 +56,13 @@ INSTALL*
 # Per-target/build subdirectories generated by CMake/VS
 *.dir/
 Testing/
+
+# Claude Code project files
+.claude/
+
+# Clion
+.idea/
+
+# SLURM benchmark artifacts
+scripts/ng_jobs.txt
+logs/

.pre-commit-config.yaml

@@ -92,6 +92,7 @@ repos:
     hooks:
       - id: markdownlint
         files: .*\.md$
+        exclude: ^(build|build_[^/]+)/
         args: ["--fix"]
 
   # -------------------------

scripts/gen_ng_jobs.py

@@ -0,0 +1,114 @@
+#!/usr/bin/env python3
+"""Generate a job manifest for the ng-route benchmark SLURM array.
+
+Each manifest line holds the CLI arguments for one ``rcspp-vrp-benchmark-ng``
+run.  By default there is one job per (instance, ng-size) pair so the SLURM
+array runs every instance in parallel; ``--group-by family`` instead emits one
+job per (family, ng-size).  ``scripts/run_ng_benchmark.slurm`` reads the line
+indexed by ``$SLURM_ARRAY_TASK_ID`` and runs it.
+
+Example:
+    python scripts/gen_ng_jobs.py --ng 3 5 8 --max-index 9
+    sbatch --array=0-80 scripts/run_ng_benchmark.slurm
+"""
+
+from __future__ import annotations
+
+import argparse
+from pathlib import Path
+
+
+def instance_names(families: list[str], max_index: int) -> list[str]:
+    """Return Solomon instance names (e.g. C101) for the given families/indices.
+
+    Args:
+        families: Instance families to include (e.g. ["C", "R", "RC"]).
+        max_index: Highest instance index; expands to <family>10<1..max_index>.
+
+    Returns:
+        The list of instance names in (index, family) order.
+    """
+    return [f"{family}10{i}" for i in range(1, max_index + 1) for family in families]
+
+
+def build_jobs(args: argparse.Namespace) -> list[str]:
+    """Build the manifest lines (one benchmark argument string per job).
+
+    Args:
+        args: Parsed command-line arguments.
+
+    Returns:
+        One argument string per job.
+    """
+    common: list[str] = ["--max-labels", str(args.max_labels)]
+    if args.cols > 0:
+        common += ["--cols", str(args.cols)]
+
+    jobs: list[str] = []
+    if args.group_by == "instance":
+        for name in instance_names(args.families, args.max_index):
+            for ng in args.ng:
+                jobs.append(" ".join(["--instance", name, "--ng", str(ng), *common]))
+    else:  # group_by == "family"
+        for family in args.families:
+            for ng in args.ng:
+                jobs.append(
+                    " ".join([str(args.max_index), "--family", family, "--ng", str(ng), *common])
+                )
+    return jobs
+
+
+def parse_args() -> argparse.Namespace:
+    """Parse command-line arguments.
+
+    Returns:
+        The parsed arguments.
+    """
+    parser = argparse.ArgumentParser(description=__doc__)
+    parser.add_argument(
+        "--ng", type=int, nargs="+", default=[3, 5, 8], help="ng-neighbourhood sizes"
+    )
+    parser.add_argument(
+        "--families",
+        nargs="+",
+        default=["C", "R", "RC"],
+        help="Solomon instance families",
+    )
+    parser.add_argument("--max-index", type=int, default=9, help="highest instance index (1..9)")
+    parser.add_argument("--max-labels", type=int, default=100, help="per-node label-expansion cap")
+    parser.add_argument(
+        "--cols", type=int, default=0, help="columns per CG iteration (0 => #customers)"
+    )
+    parser.add_argument(
+        "--group-by",
+        choices=["instance", "family"],
+        default="instance",
+        help="one job per instance (default) or per family",
+    )
+    parser.add_argument(
+        "--output",
+        type=Path,
+        default=Path("scripts/ng_jobs.txt"),
+        help="manifest output path",
+    )
+    return parser.parse_args()
+
+
+def main() -> None:
+    """Generate the manifest and print the matching sbatch command."""
+    args = parse_args()
+    jobs = build_jobs(args)
+
+    args.output.parent.mkdir(parents=True, exist_ok=True)
+    args.output.write_text("\n".join(jobs) + "\n")
+
+    print(f"Wrote {len(jobs)} jobs to {args.output}")
+    print("Submit with:")
+    print(
+        f"  MANIFEST={args.output} sbatch --array=0-{len(jobs) - 1} "
+        f"scripts/run_ng_benchmark.slurm"
+    )
+
+
+if __name__ == "__main__":
+    main()

scripts/run_ng_benchmark.slurm

@@ -0,0 +1,54 @@
+#!/bin/bash
+# SLURM array runner for the ng-route augmentation benchmark.
+#
+# It executes one job from a manifest generated by scripts/gen_ng_jobs.py:
+# array task N runs the (N+1)-th manifest line through rcspp-vrp-benchmark-ng.
+# By default the manifest has one line per (instance, ng-size), so every
+# instance runs in parallel.
+#
+# Usage (submit from the repository root; the binary locates instances/ relative
+# to the source tree baked in at compile time):
+#   python scripts/gen_ng_jobs.py --ng 3 5 8 --max-index 9
+#   MANIFEST=scripts/ng_jobs.txt sbatch --array=0-80 scripts/run_ng_benchmark.slurm
+#
+# The --array range must equal the number of manifest lines (printed by the
+# generator). Override MANIFEST / BIN via --export, e.g.:
+#   sbatch --array=0-26 --export=ALL,MANIFEST=scripts/ng_jobs.txt scripts/run_ng_benchmark.slurm
+
+#SBATCH --job-name=ng-bench
+#SBATCH --array=0-80
+#SBATCH --cpus-per-task=1
+#SBATCH --mem=8G
+#SBATCH --time=12:00:00
+#SBATCH --output=logs/ng_%A_%a.out
+#SBATCH --error=logs/ng_%A_%a.err
+
+set -euo pipefail
+
+MANIFEST="${MANIFEST:-scripts/ng_jobs.txt}"
+BIN="${BIN:-./build/bin/rcspp-vrp-benchmark-ng}"
+task="${SLURM_ARRAY_TASK_ID:-0}"
+
+if [[ ! -f "${MANIFEST}" ]]; then
+  echo "Manifest not found: ${MANIFEST} (run scripts/gen_ng_jobs.py first)" >&2
+  exit 1
+fi
+if [[ ! -x "${BIN}" ]]; then
+  echo "Benchmark binary not found/executable: ${BIN}" >&2
+  echo "Build it first, e.g.: cmake --build build --target rcspp-vrp-benchmark-ng" >&2
+  exit 1
+fi
+
+# Manifest is 0-indexed by array task; sed is 1-indexed.
+line="$(sed -n "$(( task + 1 ))p" "${MANIFEST}")"
+if [[ -z "${line}" ]]; then
+  echo "No manifest line for array task ${task} in ${MANIFEST}" >&2
+  echo "Set --array to match the number of lines ($(wc -l < "${MANIFEST}"))." >&2
+  exit 1
+fi
+
+mkdir -p logs
+read -r -a job_args <<< "${line}"
+echo "[$(date '+%F %T')] task=${task} args: ${line}"
+
+srun "${BIN}" "${job_args[@]}"

src/python/conftest.py

@@ -12,3 +12,10 @@ def pytest_configure(config):
         message=".*SolverGurobi.*",
         category=pytest.PytestUnraisableExceptionWarning,
     )
+    # pytest's internal cache plugin leaves sqlite3 connections open; suppress the
+    # resulting ResourceWarning so it doesn't pollute test output.
+    warnings.filterwarnings(
+        "ignore",
+        message=".*unclosed.*<sqlite3.Connection.*",
+        category=ResourceWarning,
+    )