remote/coordinator: publish correct place after reservation re-scheduling#1869
Open
alextercete wants to merge 1 commit into
Open
remote/coordinator: publish correct place after reservation re-scheduling#1869alextercete wants to merge 1 commit into
alextercete wants to merge 1 commit into
Conversation
…ling Fix a bug in schedule_reservations() where the update notification could publish a stale/incorrect place due to reuse of a loop variable. Now it publishes the place corresponding to the name whose reservation mapping actually changed. Signed-off-by: Alex Tercete <alex.tercete@arm.com> Reviewed-by: Alex Tercete <alex.tercete@arm.com> # gatekeeper Co-authored-by: Idan Saadon <idan.saadon@arm.com>
alextercete
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1869 +/- ##
======================================
Coverage 46.0% 46.0%
======================================
Files 180 180
Lines 14439 14439
======================================
Hits 6654 6654
Misses 7785 7785
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Emantor
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Small bug fix in
schedule_reservations()where the update notification could publish a stale/incorrect place due to reuse of a loop variable. Now it publishes the place corresponding to the name whose reservation mapping actually changed.Checklist