fix stale vote submission error after reset

[laceyp99]

Summary

• Clear failed submission status, message, and log warnings when resetting an active vote.
• Add regression coverage that verifies the stale error banner is hidden after reset.

Testing

• py -3.13 -m ruff format --check . - passed
• py -3.13 -m ruff check . - passed
• py -3.13 -m pytest - passed (112 tests)

[laceyp99]

Good simple fix. Just cleaning it up properly and a regression test. Love it!

[github-actions]

Agent PR review

Validation

Validation passed: python -m ruff format --check ., python -m ruff check ., and python -m pytest all completed successfully.

Summary

PR #38 clears stale vote submission state during reset_vote, specifically log_warning, submission_status, and submission_message, and adds a regression test for hiding the stale error banner after reset.

Issues and risks

No blocking issues found. The change in arena/state/voting.py matches the stated intent and preserves the existing guards for missing, submitted, or not-ready rounds.

Test coverage

The new unit test covers the failed-submission reset path and asserts both state clearing and hidden status UI. Existing integration tests already cover failed vote submission and retry behavior.

Local scoped checks passed:

• python -m ruff format --check arena tests
• python -m ruff check --no-cache arena tests
• git diff --check ...

I could not run local pytest fully in this sandbox because there is no writable temp directory. The provided review context reports the full project validation passed: ruff format --check ., ruff check ., and pytest.

Recommendation

Looks safe to continue review.

---

This is an automated review. Please treat it as advisory; human review is still required.