You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Validation passed: python -m ruff format --check ., python -m ruff check ., and python -m pytest all completed successfully.
Summary
The PR changes streamed generation logging so final_response is accumulated only from streamed deltas, while warnings/errors are rendered as separate completed status messages. It also updates serialization and adds regression coverage for partial-response failures, unsupported reasoning warnings, and background stream failures.
Issues and risks
No blocking issues found.
I reviewed README.md, confirmed no AGENTS.md exists, read codex-review-context.md, and compared origin/pr/39 against origin/main. The changed paths in arena/app.py and arena/ui/display.py appear consistent with the stated intent: UI status messages no longer overwrite or contaminate the logged model response.
Test coverage
The PR adds focused coverage for:
preserving partial streamed output after an error
storing warning/error messages as metadata-bearing completed messages
preserving accumulated final_response
handling concurrent background stream failures
The review context reports these checks passed: python -m ruff format --check ., python -m ruff check ., and python -m pytest. I did not rerun them locally because the workspace is read-only.
Remaining non-blocking gap: there does not appear to be a browser-level Gradio smoke test proving the new gr.ChatMessage metadata renders exactly as intended after serialization/reload.
Recommendation
Looks safe to continue review.
This is an automated review. Please treat it as advisory; human review is still required.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
final_responseso UI decorations cannot corrupt generation logsCloses #24
Testing
py -3.13 -m ruff format --check .- passedpy -3.13 -m ruff check .- passedpy -3.13 -m pytest -q- passed (113 tests)