fix(evaluator): simplify provider concurrency handling - #27
Merged
Merged
Conversation
laceyp99
marked this pull request as ready for review
August 13, 2026 05:28
6 tasks
laceyp99
commented
Aug 14, 2026
laceyp99
left a comment
Owner
Author
There was a problem hiding this comment.
Reviewed! Everything looks good after the commit I made, as it cleaned up the visual display of the generation failures on the dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rate_limitedevaluation outcome in persisted results, summaries, and analysis viewsDecision and reasoning
The previous implementation described its semaphore as RPM-based rate limiting, but a semaphore only bounds simultaneous requests; it cannot enforce requests per minute.
#26 explored a comprehensive Eval-owned scheduler with per-model RPM pacing, separate model and global concurrency caps, a provider-dispatch acknowledgement boundary, typed throttling behavior, and durable task manifests and transition journals. That work demonstrated a viable direction, but it also introduced a large scheduling and recovery subsystem into Eval. We closed that PR as an implementation alternative because its complexity is disproportionate to the current personal-evaluator use case, not because strict quota handling is no longer valuable.
This PR takes the smaller, explicit step: Eval owns provider-scoped concurrency and makes persistent throttling observable. It does not present that control as complete rate limiting.
Current behavior
max_cloud_concurrency.rate_limitedand remains distinct in summaries and analysis views. The overview card names a single exception type, aggregates mixed run exceptions, and reportsN/Awhen no pass-rate-eligible results exist.Future rate-limiting work
We are still considering the correct long-term design for rate limiting. A robust solution needs to account for RPM and TPM together rather than pacing only request starts, and may also need to consider RPD, account-tier overrides, token estimation and reconciliation,
Retry-Afterbehavior, SDK retry ownership, and coordination across concurrent runs.That likely requires coordinated work in both
conductor-coreandconductor-eval, with quota ownership placed near Core's provider dispatch boundary while Eval remains a consumer of the public engine. Issue #10 therefore remains open as an enhancement while that design is worked through.Validation
uv sync --locked --all-extrasuv run --locked --all-extras ruff format --check .uv run --locked --all-extras ruff check .uv run --locked --all-extras pytest -q— 129 passeduv build