migrate to conductor-core v0.5.0 - #22
Merged
Merged
Conversation
laceyp99
marked this pull request as ready for review
September 3, 2026 21:56
laceyp99
commented
Sep 4, 2026
laceyp99
left a comment
laceyp99
left a comment
Owner
Author
There was a problem hiding this comment.
Looks good to merge! I ran a couple test runs with new models and rerendering audio after moving the selected soundfont file, and all gracefully succeeded.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
conductor-coredependency from v0.4.0 to v0.5.0AudioRenderingErrorcontract while preserving existing audio on failureTesting
uv sync --locked --extra dev- passeduv run --locked --extra dev ruff format --check .- passeduv run --locked --extra dev ruff check .- passeduv run --locked --extra dev pytest -q- passed (42 passed, 1 platform-specific security test skipped)uv build- passedNotes