add a packaged Windows release path - #49
Conversation
|
RC-002 (Medium):
This PR made Suggestion: make the default path bundle-aware when |
Update summary
Testing
Notes
|
Whisper only shells out to FFmpeg for audio file paths; Murmur always passes recorded audio arrays to the model and writes training audio with the stdlib wave module, so FFmpeg is not a runtime dependency. Remove it from the requirements table, install steps, and packaged-release notes.
SummaryFix RC-006: a windowless packaged launch could exit before the tray appeared when Whisper needed to download its model. The download progress bar attempted to write to a missing terminal stream. Existing cached models bypassed this path, so the normal packaged self-check did not expose the failure. Changes
Validation
Notes
|
Final validation updatePushed commit Validation
Automated formatting, lint, tests, documentation, packaging, metadata, and packaged dependency self-checks passed during the gauntlet. The only remaining notes are the existing optional PyInstaller |
laceyp99
left a comment
There was a problem hiding this comment.
This looks good but before I merge, I feel like we should see if there is a cleaner packaging without needing the internal directory structuring to be moved around with the murmur.exe file.
Packaging conclusionResolved for the current release path with commit The confirmed workflow is to distribute the complete ZIP package, extract it to: The packaged files remain together, and users may create an optional Desktop shortcut to The user validated this workflow, including packaged startup, tray behavior, notifications, dictation, clipboard delivery, CUDA/GPU transcription, Ollama cleanup, and autostart persistence. Future installer work is tracked in #50. The recommended first implementation is an Inno Setup installer around the existing onedir payload, with per-user installation, Start Menu and optional Desktop shortcuts, upgrade preservation of |
laceyp99
left a comment
There was a problem hiding this comment.
Alright with everything finally addressed. This looks good to merge! We'll revisit the installer within it's own PR.
Summary
onedirrelease path that producesdist\Murmur\murmur.exewithout changing the Python development workflow.@laceyp99through.github/CODEOWNERS.Closes #48.
Validation
venv\Scripts\python.exe -m pip install -e ".[dev]"venv\Scripts\ruff.exe format --check .venv\Scripts\ruff.exe check .venv\Scripts\pytest.exe(185 passed)venv\Scripts\python.exe -m mkdocs build --strictpowershell -ExecutionPolicy Bypass -File .\build_windows.ps1Notes
onedirbundle is approximately 575 MiB and must be distributed as a complete folder.tbb12.dll; Murmur's packaged Whisper and Torch self-check passes without that backend.