Skip to content

refactor tests - #45

Merged
lackhove merged 4 commits into
mainfrom
refac/tests
Apr 4, 2026
Merged

lackhove merged 4 commits into
mainfrom
refac/tests

Conversation

@lackhove

Copy link
Copy Markdown
Owner

No description provided.

@lackhove
lackhove force-pushed the refac/tests branch 2 times, most recently from 51ce029 to 217d52f Compare March 31, 2026 20:04
@cdleonard

Copy link
Copy Markdown
Contributor

The example/.coverage binary should not be added to source control. Maybe it was added by mistake?

It would make sense to add coverage.json and then have a test_example that runs the example and compares json output with "gold version". But I see that the example project isn't used in tests at all???

I think having an example project that you can play with stand-alone and which is also used from pytest makes sense.

@lackhove

lackhove commented Apr 4, 2026

Copy link
Copy Markdown
Owner Author

@cdleonard The problem with using the example as a test is that it would fail every time something changes in the code, causing false positives. we had the same issues with the growing number of e2e tests. For a project as small a this one, thats probably not an issue but still something that bugs me 🤷 . OTOH when including an example, we should ensure it works. So i think the best compromise is to add a test that only verifies the plugin does not crash for the example, without verifying its result.

@lackhove
lackhove merged commit 94f7d65 into main Apr 4, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants