refactor tests - #45
Conversation
51ce029 to
217d52f
Compare
|
The It would make sense to add coverage.json and then have a test_example that runs the example and compares json output with "gold version". But I see that the example project isn't used in tests at all??? I think having an example project that you can play with stand-alone and which is also used from pytest makes sense. |
|
@cdleonard The problem with using the example as a test is that it would fail every time something changes in the code, causing false positives. we had the same issues with the growing number of e2e tests. For a project as small a this one, thats probably not an issue but still something that bugs me 🤷 . OTOH when including an example, we should ensure it works. So i think the best compromise is to add a test that only verifies the plugin does not crash for the example, without verifying its result. |
No description provided.