Fix pre-commit by removing the mypy hook - #47
Merged
Merged
Conversation
This does not currently work because pre-commit executes hooks in a private venv and mypy requires the projects own dependencies. It's possible to make this pass by duplicating dependencies into the pre-commit config file but it is not worth it.
By executing pre-commit inside CI we ensure that the config works.
This reverts commit a886ae2.
Owner
|
Thanks for the hint! This reminds me of why i never liked pre-commit. Id like to keep the dotfile around for those who use but rather not have to deal with it in CI. I will revert that commit and merge. |
Contributor
Author
|
I generally always add pre-commit into CI scripts and it works fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This does not currently work because pre-commit executes hooks in a private venv and mypy requires the projects own dependencies.
It's possible to make this pass by duplicating dependencies into the pre-commit config file but it is not worth it.
Also run pre-commit inside github to ensure config is always appropriate.