plugin: remove subshell and pipeline from EXECUTABLE_NODE_TYPES - #49
Merged
lackhove merged 4 commits intoApr 28, 2026
Merged
Conversation
A subshell open parenthesis is never reported as "executed" by bash so we shouldn't mark at as "executable". It should be treated the same as a "compound_statement".
The pipeline not is a container for multiple "command" children, it does it need to be marked executable by itself. This fixes empty braces at the start of a pipeline being reported as uncovered.
An empty brace part of a pipeline is not reported as "executed" by bash and should not be marked as "executable", otherwise it will incorrectly end up as "uncovered".
cdleonard
force-pushed
the
feature/fix-subshell-open-paren
branch
from
April 21, 2026 12:36
45c2869 to
32607fb
Compare
cdleonard
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A "subshell" is a container for executable commands but is not by itself executable. Treat it just like "compound_statement".
Same logic applies to "pipeline". Removing this fixes incorrectly reported uncovered first line in following example:
Fixes #48