Skip to content

Avoid cross-repository PR shorthand misattribution - #148

Merged
laclance merged 4 commits into
devfrom
fix/external-pr-shorthand-attribution
Oct 7, 2026
Merged

laclance merged 4 commits into
devfrom
fix/external-pr-shorthand-attribution

Conversation

@laclance

@laclance laclance commented Oct 7, 2026

Copy link
Copy Markdown
Owner

Summary

Fix the spurious production lookup seen in private run #13:

Nakagawa-master/nakagawa-theory-archive PR #13406

The source comment explicitly identifies Qwen's external PR:

https://github.com/QwenLM/qwen-code/pull/13406

but also repeats implementation PR #13406. The scanner treated that shorthand as if it belonged to the issue repository and attempted a bogus same-repository PR lookup.

This keeps the existing same-repository shorthand mechanism, but ignores a shorthand when a nearby fully-qualified PR URL with the same number clearly points to a different repository.

Regression coverage

  • production-shaped Nakagawa/Qwen PR #13406 echo does not trigger a same-repo lookup
  • a distant external PR with the same number does not suppress a genuine same-repo shorthand
  • existing same-repo shorthand behavior remains covered

Scope

Only:

  • opportunity_scout/strategic/competition.py
  • tests/strategic/test_competition.py

No readiness, scoring, private-instance, or release changes.

@laclance
laclance marked this pull request as ready for review October 7, 2026 15:50
@laclance
laclance merged commit 12e5aed into dev Oct 7, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant