Skip to content

Silence stale platform source 404s - #149

Merged
laclance merged 1 commit into
devfrom
fix/silent-stale-platform-source
Oct 7, 2026
Merged

laclance merged 1 commit into
devfrom
fix/silent-stale-platform-source

Conversation

@laclance

@laclance laclance commented Oct 7, 2026

Copy link
Copy Markdown
Owner

Summary

Treat missing GitHub issues discovered from third-party bounty-platform feeds as the stale references they already semantically are, without printing them as scanner API failures.

Private run #13 surfaced two examples:

  • sentryco/Telemetry#2
  • buape/kiai-bounties#1

Both repositories are now absent on GitHub. issue_from_github_url_checked already returns (None, None) for HTTP 404 so these candidates are skipped without a source failure, but it logged GitHub API Error (not found) before applying that rule.

This moves the log after the 404 stale-reference check.

Regression coverage

  • HTTP 404 remains a silent stale-reference skip
  • non-404 API failures still emit GitHub API Error
  • non-404 failures still return SourceFailureReason

Scope

Only:

  • opportunity_scout/github.py
  • tests/test_github.py

No platform parsing, candidate policy, private-instance, or release changes.

@laclance
laclance marked this pull request as ready for review October 7, 2026 15:58
@laclance
laclance merged commit d5d0481 into dev Oct 7, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant