Repository navigation
Prevent negated maintainer readiness from approving strategic issues - #193
Merged
Merged
Conversation
laclance
marked this pull request as ready for review
October 9, 2026 11:16
laclance
added a commit
that referenced
this pull request
Oct 9, 2026
Release promotion of five reviewed fixes: durable recovery output formatting; upstream Go-tool attribution; architecture proposal approval; negated maintainer readiness; and proxy-header feature versus existing-regression classification. Includes #190, #191, #192, #193 and #194. Preserve dev squash-only history.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finding
The shared readiness detector considered the phrase
ready for implementationan approval even when embedded inNot ready for implementation. Because positive readiness is evaluated before maintainer hold logic, an explicit refusal could be misread as permission, allowing a strategic proposal or upstream-tool issue into the queue.Fix
Scope
Narrow readiness correctness fix. No other audit findings addressed, no private-instance deployment, no changes to paid, discovery, scoring, state persistence, or delivery.
Validation
Requires green CI formatting/lint, strict types, coverage and Python compatibility. Remains a draft PR until explicitly authorized for merge.