fix(cli): align MCP audit verdicts with anchors - #496
Open
LunaMeerkats wants to merge 1 commit into
Open
LunaMeerkats wants to merge 1 commit into
LunaMeerkats wants to merge 1 commit into
Conversation
Contributor
Author
|
Hosted Rust validation has now measured the full workspace at the exact head: The two-test delta is exactly the two regressions added here; the run reports no test failure. This environment could not make that measurement locally because the WSL GUI development libraries are absent. Under the documented All other completed executable checks are green; |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make
sysknife_audit_verifyresolve the configured checkpoint anchor once and use the same combined verdict rule assysknife audit verify --json.cannot_verifythrough MCP instead ofintactbrokenaudit_anchorobject while retaining its existing flattened chain, approval, binding, attribution, and host fieldsThis combines the two gaps requested in #478 and #466. Closes #478. Closes #466.
Related Issue
Validation
Executed from WSL at base
f22a6abdand headd9fd70d:cargo test -p sysknife-cli --bins --tests --locked: 303 passed, 1 documented live-Postgres test ignored, 0 failedcargo clippy -p sysknife-cli --all-targets --locked -- -D warnings: passedcargo fmt --all -- --check: passedgit diff --check: passedpython scripts/check_evidence_claims.py: passedMutation proof: replacing the shared combined verdict with the chain-only exit code made both new regressions fail: empty/unanchored returned
intactinstead ofcannot_verify, and the truncated anchor returnedintactinstead ofbroken. Restoring the hunk returned both to green.The broader
cargo test --workspace --lockedattempt stopped during dependency build because this WSL environment lacks the GTK/GLib development packages (glib-2.0,gobject-2.0, andgdk-3.0).cargo nextestis not installed here. Per the documented fallback, I left the generated workspace-test evidence and prose totals untouched for the maintainer/CI environment.Notes for Reviewers
AuditVerifyReportdoes not literally mirror every nested CLI JSON field: it preserves its established flattened MCP fields. Its contract now explicitly promises the same headline verdict andaudit_anchorcross-check, and those are generated by shared CLI helpers.This pull request was prepared and published autonomously with Codex under the
LunaMeerkatsaccount. No generated output was accepted without inspecting the diff and running the checks listed above.