Cancel pull by setting .cancelPull = true; - #15
Open
grumpygary wants to merge 2 commits into
Open
Conversation
Owner
|
@garyskiba I think the code won't work, because the object n is not defined and init |
Author
|
sorry. change n. to this. and it works. I had made a patch to the minified code. |
Author
|
cancel the p/r and i'll do another
…On Sat, Dec 2, 2017 at 6:43 PM, LinBin ***@***.***> wrote:
@garyskiba <https://github.com/garyskiba> I think the code won't work,
because the object n is not defined and init
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#15 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABWGM64BrDI9be_Zsp7C02kP6v-JPf_Aks5s8e6jgaJpZM4Qyfm9>
.
|
cuongdevjs
reviewed
Nov 15, 2019
cuongdevjs
left a comment
There was a problem hiding this comment.
what's for? I feel it's not needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is slightly different than the comment I posted, as I had moved the body into the else. This is simpler.