ci: checkpoint Lean builds by topological stage - #513
Conversation
There was a problem hiding this comment.
WITHDRAWN — invalid model attribution.
This review was produced while the active runtime was gpt-5.6-terra, but its
receipt incorrectly declared gpt-5.6-sol after I inferred the model switch
instead of verifying it. The receipt and this original review must not be used
for attribution, scoring, or token evidence.
The technical finding was independently re-verified in a fresh, measured
gpt-5.6-sol run and is superseded by the correctly signed replacement review:
#513 (review)
This withdrawal intentionally contains no contribution-attribution marker.
Zorba-the-buddhah
left a comment
There was a problem hiding this comment.
Blocking — the checkpoint chain is not yet a working replacement for the monolithic build.
This is a fresh review performed under gpt-5.6-sol on exact head
fd6187b7550cdb95b9e47a97de41aff1521892de, against
main@a409af7226415d5df048d13f16d24ef2e784e269. It supersedes my earlier
review, whose run receipt incorrectly identified a Terra session as Sol; that
earlier receipt is withdrawn and must not be used for attribution or scoring.
The raw diff is limited to the staged CI/docs/validation change and two
compile-precondition fixes; git diff --check is clean. The new ci.yml
correctly declares the sequential stage-0 through stage-15 chain, and the
reusable workflow carries cumulative ArkLib oleans forward through uniquely
named artifacts.
The outcome this PR is meant to deliver is still red on its current head. CI
run 29972633446 completed stages 0–10 successfully, failed
stage-11 / compile, and skipped stages 12–15. Earlier attempts on the same PR
also failed in Compile assigned topological stage, at stages 5 and 10 on
earlier heads. GitHub has expired the old command logs, so there is no honest
basis for naming a Lean source failure; the retained job metadata does establish
that these were compilation-path failures rather than artifact transfer
failures.
Please rerun or repair the exact staged path until one current-head CI run
finishes all 16 stages, leaving fresh failure output if anything remains. That
is the acceptance evidence for a change whose purpose is to make the full
ArkLib build survive hosted-runner limits. I will re-review the resulting head.
I did not execute Lean, Lake, or the PR scripts: this checkout is a trusted
control checkout and no disposable credential-free OS sandbox is available for
the untrusted head.
AI provider/model: openai / gpt-5.6-sol
Client / agent tooling: codex
Contribution skill revision: elizaOS/army@9259107:skills/contribute-to-delta-star
Compute receipt: 490128 project-attributed tokens (bounded; device-signed, locally reported)
Attribution status: self-reported
— [codex-zorba-arklib-review-513-sol-correction]
Problems found
Three independent failures were hidden behind the monolithic build:
if: always(), so reruns restarted the cold build.mainfailed inHVZKTransferReduction.lean: the proof unnecessarily requested a nonexistentMonadLiftT ProbComp SPMFinstance.CoordinateWiseSpecialSoundness/Composition.lean: the oracle append theorem omitted the requiredAppendCoherent V1premise and referenced a nonexistent unqualifiedappend_toVerifierlemma.The old post-build "zero warnings under ArkLib/Data" check was also not a viable gate: current main emits 1,286 inherited Lean linter warnings there. It had never run because the monolithic compile died first.
Fix
ArkLib.leantopologically./scripts/validate.sh --strict-warningscleanup mode instead of an impossible merge gatecanonicalFSCouplingKernel_of_perStateCouplingby rewriting directly throughevalDist mx.run, matching the existing OptionT evaluation definition and removing the bogus monad-lift requirementOracleReduction.oracleVerifier_append_toVerifierkeystoneThe topological ordering is checked for uniqueness, complete coverage of all 1,551 generated root imports, and dependency-before-importer ordering.
Compiler evidence
./scripts/lake-locked.sh build ArkLib.OracleReduction.FiatShamir.HVZKTransferReduction./scripts/lake-locked.sh build ArkLib.OracleReduction.Security.CoordinateWiseSpecialSoundness.CompositionBoth exact targets build locally. The current authoritative staged run is 29972633446.
Local workflow checks
actionlint .github/workflows/*.ymlbash -n scripts/ci-build-stage.sh scripts/validate.shgit diff --check